[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990525#comment-14990525
]
Ryan Blue commented on AVRO-1747:
---------------------------------
Matthieu, here are a few things I noticed:
1. The new files should have the [Apache license
header|https://www.apache.org/legal/src-headers.html#headers] because they will
be licensed by you to the ASF. (You may alternatively want to donate the code
to the ASF, in which case let us know and we will help you through that
process.)
2. At least one file, browser/crypto.js, has code that was copied from
elsewhere. In those cases, we need to make sure that we are respecting the
original license terms for that code. We do that by updating the LICENSE and
NOTICE files appropriately. I can help you through that process, but to start
we need to identify all of the places where you've included code from other
sources and determine the license for it. Unfortunately, I couldn't find a
license for the MD5 implementation so we might have to contact the author for
one.
3. Nice work on the validator port. Two of the compatibility notes caught my
attention. Could you elaborate on: "the validator's schema property isn't
available"? Also, it says "extra fields in records are ignored". What about
adding a "strict" flag to the API to turn that on or off? Then we could keep
from breaking the current behavior.
4. How does packaging work? Typically, {{build.sh dist}} is used to create the
binary package that will be distributed. This is served from Apache and copied
to the relevant distribution network (in this case, npm). I see that this
doesn't build a package, but I think it is distributed by npm. I think we
should integrate the two so that the npm artifact can be verified as part of
the release. It will contain a LICENSE and NOTICE file for just the js
implementation for downstream consumers, too.
> JavaScript implementation
> -------------------------
>
> Key: AVRO-1747
> URL: https://issues.apache.org/jira/browse/AVRO-1747
> Project: Avro
> Issue Type: Improvement
> Components: javascript
> Reporter: Matthieu Monsch
> Attachments: AVRO-1747.patch
>
>
> Hello,
> I'm not sure if there is still interest in a JavaScript implementation of the
> Avro spec, or if this is the right place for this message (apologies if not),
> but in case it's useful here is one: https://github.com/mtth/avsc
> It's pretty fast, fully featured aside from protocols (AFAIK), and runs in
> the browser.
> Disclaimer: I wrote this library. (I initially searched around for existing
> implementations, and even saw a few tickets on this board about JavaScript
> decoders, but couldn't find one to support the schemas I have to process.)
> Best,
> -Matthieu
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
