[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289414#comment-15289414
]
Ryan Blue commented on AVRO-1847:
---------------------------------
Thanks for working on this, [~Yibing]. For specific, we have to do a bit more
work than just adding the conversion. The IDL would need to have a
"decimal(S,P)" type added or else this will only work when compiling schemas.
We also need to add tests, like the ones that were added for date, time, and
timestamp that verify this works and is compatible with classes generated by
older versions of the compiler. I'm glad to see that it's so close to working
with small changes, though. Shouldn't be too much more work to get this in.
> IDL compiler uses ByteBuffer for decimal type even if logical type is
> supported
> --------------------------------------------------------------------------------
>
> Key: AVRO-1847
> URL: https://issues.apache.org/jira/browse/AVRO-1847
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.8.0
> Reporter: Yibing Shi
> Attachments: AVRO-1847.1.patch
>
>
> Version 1.8.0 has added the support of logical types. A conversion class
> (Conversions.DecimalConversion) has also been added for decimal type.
> However, the IDL compiler still uses ByteBuffer for decimal types, which is
> not the same behaviour as data, time or timestamp type (added in AVRO-1684).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
