-1 from me. C# tests fail to run. The source of the problem is as follows: Prior to this tag, the lang/csharp/build.sh file contained the test line: nunit-console --framework=4.0 Avro.nunit
>From discussion with @jcustenborder, it seems like the C# tests won't run on a Mac if we keep the --framework=4.0 in this line; removing it (as has been done for 1.8.2) makes the tests run. But removing it makes the tests fail on my system (CentOS 7). This suggests that something is missing from the docker setup and is being picked up from the host computer, but I haven't had a chance to investigate. Given that it's a choice between it passing for me or passing on all Macs everywhere, go ahead and release. I'll chase this up for the 1.8.3 release. All tests other than the C# pass when running build.sh test from docker. Simon On Sun, Nov 6, 2016 at 9:59 PM, Ryan Blue <b...@apache.org> wrote: > Hi everyone, > > I propose the following RC to be released as official Apache Avro 1.8.2 > release. > > The commit id is 7ec35ea24ff0270586a26afbc6f6f530d272d1f7 > * This corresponds to the tag: release-1.8.2-rc1 > * https://github.com/apache/avro/tree/7ec35ea2 > * > https://git-wip-us.apache.org/repos/asf/projects/repo?p= > avro.git&a=commit&h=7ec35ea2 > > The release tarball, signature, and checksums are here: > * https://dist.apache.org/repos/dist/dev/avro/avro-1.8.2-rc1/ > > You can find the KEYS file here: > * https://dist.apache.org/repos/dist/release/avro/KEYS > > Binary artifacts for Java are staged in Nexus here: > * https://repository.apache.org/content/groups/staging/org/apache/avro/ > > This release includes: > * A spec for single-message Avro encoding and a Java implementation > * Java: Bug fixes for Java logical types > * Java: Support for Decimal with specific classes > * Ruby: A fix for compatibility when using snappy > * Python 3: Updated to use the standard module-level logging pattern > * C++: Support for Boost >= 1.59 > * And more bug fixes... > > Please download, verify, and test, then please vote by the end of > Wednesday, 9 November. > > [ ] +1 Release this as Apache Avro 1.8.2 > [ ] +0 > [ ] -1 Do not release this because... > > > -- > Ryan Blue >
