[
https://issues.apache.org/jira/browse/AVRO-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667573#comment-15667573
]
ASF GitHub Bot commented on AVRO-1542:
--------------------------------------
GitHub user sanjosh opened a pull request:
https://github.com/apache/avro/pull/157
AVRO-1542 replacing auto_ptr by unique_ptr & std::move
Please verify
1) addition of flags to CMakeLists.txt and
2) one case where auto_ptr was being passed by reference but is now changed
to pass unique_ptr by value in lang/c++/impl/FileStream.cc : 193
all tests passed in my local build
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sanjosh/avro master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/avro/pull/157.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #157
----
commit b26e3431bcbde97470d38bdb0e5470b0f1a60086
Author: Sandeep Joshi <[email protected]>
Date: 2016-09-20T07:30:27Z
AVRO-1542 replacing auto_ptr by unique_ptr & std::move
----
> std::auto_ptr
> -------------
>
> Key: AVRO-1542
> URL: https://issues.apache.org/jira/browse/AVRO-1542
> Project: Avro
> Issue Type: Improvement
> Components: c++
> Affects Versions: 1.7.6
> Reporter: Sean Middleditch
> Priority: Trivial
>
> std::auto_ptr is deprecated, meaning that it may be removed from a future
> version of the C++ standard (though vendors would not likely remove it...
> probably).
> Avro should at its next API-breaking opportunity replace its use of auto_ptr
> with std::unique_ptr or shared_ptr or a custom smart pointer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
