[
https://issues.apache.org/jira/browse/AVRO-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897217#comment-15897217
]
ASF GitHub Bot commented on AVRO-1542:
--------------------------------------
GitHub user ecatmur opened a pull request:
https://github.com/apache/avro/pull/203
AVRO-1542: Replace deprecated std::auto_ptr
Replace deprecated std::auto_ptr with boost::movelib::unique_ptr.
> boost::movelib::unique_ptr is a drop-in replacement for std::unique_ptr,
usable also from C++03 compilers.
This supersedes https://github.com/apache/avro/pull/157
Note that some deprecation warnings remain because of transitive includes
through Boost libraries (ptr_vector, iostreams) depending on Boost version.
Tested in C++11 mode with gcc 5.4.0, in C++03 mode with gcc 4.9.2.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ecatmur/avro avro-1542
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/avro/pull/203.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #203
----
commit a985b4daa8ee309948e6470ab64207ddf31bdea7
Author: Edward Catmur <[email protected]>
Date: 2017-03-06T11:53:05Z
AVRO-1542: Replace deprecated std::auto_ptr with boost::movelib::unique_ptr
commit 86a84f6b3ddd4d0fd8b3a28acd124a9dab8e4600
Author: Edward Catmur <[email protected]>
Date: 2017-03-06T12:35:19Z
Missed some cases
commit ec225fba9dc57e19f6af26876d261dacf9c0775a
Author: Edward Catmur <[email protected]>
Date: 2017-03-06T12:38:36Z
Missed some cases
commit ff3ddcd9e2697b299181eaca8b3a7607ac9ef8f1
Author: Edward Catmur <[email protected]>
Date: 2017-03-06T12:50:21Z
C++03 fix
----
> std::auto_ptr
> -------------
>
> Key: AVRO-1542
> URL: https://issues.apache.org/jira/browse/AVRO-1542
> Project: Avro
> Issue Type: Improvement
> Components: c++
> Affects Versions: 1.7.6
> Reporter: Sean Middleditch
> Priority: Trivial
>
> std::auto_ptr is deprecated, meaning that it may be removed from a future
> version of the C++ standard (though vendors would not likely remove it...
> probably).
> Avro should at its next API-breaking opportunity replace its use of auto_ptr
> with std::unique_ptr or shared_ptr or a custom smart pointer.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
