-1

I agree with Niels. We should fix the file header before releasing.

On Thu, Apr 6, 2017 at 12:46 AM, Niels Basjes <[email protected]> wrote:
> Hi,
>
> NOTE: I'm at the Hadoop Summit in Munchen Germany with limited tools (and
> limited power for my laptop) here.
>
> I did a git clone of the avro code based and checked out the project at
> commit
> 6bbcf7658e31cd7e92c459300fd70263b9b89de6
>
> I found a simple problem that needs to be fixed:
> Running ./build.sh rat reveals a build failure caused by a missing
> copyright comment in
> lang/java/avro/src/test/java/org/apache/avro/TestFixed.java
>
> Niels Basjes
>
>
>
>
> On Thu, Apr 6, 2017 at 12:16 AM, Harsha <[email protected]> wrote:
>
>> Sean,
>>      Agree on most of points made here. I am new to the avro project but
>> also active committer/PMC in other apache projects.
>> I understand that contributors can help getting the reviews up to the
>> speed but at the end of the day patches need to be merged
>> in to make it into the release.
>> There are quite a few patches with reviews available but not much activity
>> in-terms of merging or any further feedback. I am happy to help
>> wherever I can. I’ll open a new thread for further discussion on this.
>>
>> To get back on track of voting.
>>
>> 1. Ran unit tests 1.8.2 rc tag
>> 2. Verified signature of artifacts
>> 3. Tested avro-java module
>>
>>
>> +1 (non-binding).
>>
>>
>> Thanks,
>> Harsha
>>
>> On Apr 5, 2017, 2:29 PM -0700, Sean Busbey <[email protected]>, wrote:
>> > Personally, I think it's more important that we get back on our
>> > footing for release cadence. There are already a ton of things in the
>> > 1.8.2 RC. We can parallelize trying to get the other noted items
>> > reviewed and then include them in a 1.8.3 release later (say with a
>> > goal of next month).
>> >
>> > I don't want to hijack Suraj's VOTE thread, but the two things we most
>> > need right now are 1) a release cadence we can use to set expectations
>> > about when something that's been merged will see the light of day and
>> > 2) more active reviewers. We're a volunteer run project, so our finite
>> > supply of folks times has to be applied to both of these if we want to
>> > succeed. If we hold up getting releases out for the work of recovering
>> > our review bandwidth we'll perpetually be stuck with no releases.
>> >
>> > Due to the project's structure, only committers can help out with the
>> > release machinery (and thanks a ton for taking this on Suraj!).
>> > However, any contributor who has a spare hour here or there can help
>> > out with reviews. For example, it takes much less effort for me as a
>> > committer to go through patches once I see someone else has already
>> > provided feedback, especially if it's someone who's been making a
>> > habit of it.
>> >
>> > On Wed, Apr 5, 2017 at 2:09 PM, Harsha <[email protected]> wrote:
>> > > Suraj,
>> > > There are further comments on this JIRA https://issues.apache.org/
>> jira/browse/AVRO-1885 to include additional patches in the release.
>> > > It looks like the patch-merge process is really slow in Avro. But It
>> would good to pick the patches raised by other users in the JIRA.
>> > > Can we do a cut with those patches in.
>> > >
>> > > Thanks,
>> > > Harsha
>> > >
>> > > On Apr 5, 2017, 1:50 PM -0700, suraj acharya <[email protected]>,
>> wrote:
>> > > > +1 Non binding
>> > > >
>> > > >
>> > > > -Suraj Acharya
>> > > >
>> > > > On Wed, Apr 5, 2017 at 3:49 PM, Suraj Acharya <[email protected]>
>> wrote:
>> > > >
>> > > > > Hi everyone,
>> > > > >
>> > > > > I propose the following RC to be released as official Apache Avro
>> 1.8.2
>> > > > > release.
>> > > > >
>> > > > > The commit id is 6bbcf7658e31cd7e92c459300fd70263b9b89de6
>> > > > > * This corresponds to the tag: release-1.8.2-rc2
>> > > > > * https://s.apache.org/avro-1.8.2-rc2
>> > > > >
>> > > > >
>> > > > > The release tarball, signature, and checksums are here:
>> > > > > * https://dist.apache.org/repos/dist/dev/avro/avro-1.8.2-rc2/
>> > > > >
>> > > > > You can find the KEYS file here:
>> > > > > * https://dist.apache.org/repos/dist/release/avro/KEYS
>> > > > >
>> > > > > Binary artifacts for Java are staged in Nexus here:
>> > > > > * https://repository.apache.org/content/repositories/
>> orgapacheavro-1010/
>> > > > >
>> > > > > This release includes:
>> > > > > * A spec for single-message Avro encoding and a Java implementation
>> > > > > * Java: Bug fixes for Java logical types
>> > > > > * Java: Support for Decimal with specific classes
>> > > > > * Ruby: A fix for compatibility when using snappy
>> > > > > * Python 3: Updated to use the standard module-level logging
>> pattern
>> > > > > * C++: Support for Boost >= 1.59
>> > > > > * And more bug fixes...
>> > > > >
>> > > > > Please download, verify, and test. This vote will remain open for
>> at least
>> > > > > 72 hours. Given sufficient votes, I would like to close it on or
>> about 9AM
>> > > > > PDT on Wednesday, 12 April 2017.
>> > > > >
>> > > > > [ ] +1 Release this as Apache Avro 1.8.2
>> > > > > [ ] +0
>> > > > > [ ] -1 Do not release this because...
>> > > > >
>> > > > >
>> > > > > --
>> > > > > Suraj Acharya
>> > > > >
>> >
>> >
>> >
>> > --
>> > busbey
>>
>
>
>
> --
> Best regards / Met vriendelijke groeten,
>
> Niels Basjes



-- 
busbey

Reply via email to