[
https://issues.apache.org/jira/browse/AVRO-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130109#comment-16130109
]
ASF GitHub Bot commented on AVRO-1658:
--------------------------------------
GitHub user przeemek opened a pull request:
https://github.com/apache/avro/pull/240
AVRO-1658: Java: Add reflection annotation @AvroDoc.
This is a follow up of Pull-Request https://github.com/apache/avro/pull/189,
where all merge conflicts are resolved and the feature is ready for
review/merge
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/przeemek/avro AVRO-1658
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/avro/pull/240.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #240
----
commit c0f1aa0ec738efcde4f48d48929f1c3d24451acf
Author: Evan McClain <[email protected]>
Date: 2016-07-30T23:47:50Z
AVRO-1658: Java: Add reflection annotation @AvroDoc.
@AvroMeta can be used for other keys, but doc is passed into the field's
constructor.
commit e86c002947f3b6463d238e10de85d259a4a52c54
Author: Evan McClain <[email protected]>
Date: 2017-04-05T02:54:23Z
Merge remote-tracking branch 'origin/master' into AVRO-1658
commit deade58297827c4cb467d5be441607cfa1d76c69
Author: Evan McClain <[email protected]>
Date: 2016-07-30T23:47:50Z
AVRO-1658: Java: Add reflection annotation @AvroDoc.
@AvroMeta can be used for other keys, but doc is passed into the field's
constructor.
commit f672635fce9ee8f68fe0da90e61c9b65f70c1fde
Author: przwik <[email protected]>
Date: 2017-08-17T08:40:29Z
Merge remote-tracking branch 'origin/AVRO-1658' into AVRO-1658-c
Conflicts:
lang/java/avro/src/test/java/org/apache/avro/reflect/TestReflect.java
commit 1c597512eb2fedc25059349f6d4cc3748299edd1
Author: przwik <[email protected]>
Date: 2017-08-17T08:43:24Z
AVRO-1658 - resolve merge conflicts
----
> Add avroDoc on reflect
> ----------------------
>
> Key: AVRO-1658
> URL: https://issues.apache.org/jira/browse/AVRO-1658
> Project: Avro
> Issue Type: New Feature
> Components: java
> Affects Versions: 1.7.7
> Reporter: Zhaonan Sun
> Assignee: Zhaonan Sun
> Labels: reflection
> Attachments:
> 0001-AVRO-1658-Java-Add-reflection-annotation-AvroDoc.patch,
> 0001-AVRO-1658-Java-Add-reflection-annotation-AvroDoc.patch,
> 0001-AVRO-1658-Java-Add-reflection-annotation-AvroDoc.patch
>
>
> Looks like @AvroMeta can't add reserved fields, like @AvroMeta("doc", "some
> doc") will have exceptions.
> I would be greate if we have a @AvroDoc("some documentations") in
> org.apache.avro.reflect
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
