[
https://issues.apache.org/jira/browse/AVRO-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641871#comment-16641871
]
ASF GitHub Bot commented on AVRO-1658:
--------------------------------------
Hillkorn commented on issue #189: AVRO-1658: Java: Add reflection annotation
@AvroDoc.
URL: https://github.com/apache/avro/pull/189#issuecomment-427846348
In Jira
https://issues.apache.org/jira/browse/AVRO-1658?focusedCommentId=16130729&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16130729
he wants to have unit tests for class level avro doc tests and as I see in
the changes he covers them
See
https://github.com/apache/avro/pull/189/files#diff-f12fe0e1e72a3f7235da43f8c631bafcR1110
for the test
and
https://github.com/apache/avro/pull/189/files#diff-f12fe0e1e72a3f7235da43f8c631bafcR1126
where it is checked.
Is still something missing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add avroDoc on reflect
> ----------------------
>
> Key: AVRO-1658
> URL: https://issues.apache.org/jira/browse/AVRO-1658
> Project: Avro
> Issue Type: New Feature
> Components: java
> Affects Versions: 1.7.7
> Reporter: Zhaonan Sun
> Assignee: Zhaonan Sun
> Priority: Major
> Labels: reflection
> Attachments:
> 0001-AVRO-1658-Java-Add-reflection-annotation-AvroDoc.patch,
> 0001-AVRO-1658-Java-Add-reflection-annotation-AvroDoc.patch,
> 0001-AVRO-1658-Java-Add-reflection-annotation-AvroDoc.patch
>
>
> Looks like @AvroMeta can't add reserved fields, like @AvroMeta("doc", "some
> doc") will have exceptions.
> I would be greate if we have a @AvroDoc("some documentations") in
> org.apache.avro.reflect
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
