[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148959#comment-16148959
]
Anders Sundelin commented on AVRO-2072:
---------------------------------------
Hi Nandor and others,
My bad, I based my pull request on my original patch, so the additional
test cases are not there, hence, are not merged into master.
Can I add the additional test cases to AVRO-2072, or should we create a
separate issue for this?
There is no semantic difference (only white-space) in the
SchemaCompatibility class itself, comparing the AVRO-1931.patch and
AVRO-1931-2.patch.
As I also have another PR open (AVRO-1933), we certainly could add the
tests there, (this patch also deals with SchemaCompatibility). But that
patch is slightly more involved, and has no real bearing on
TestReadingWritingDataInEvolvedSchemas.
I seem to recall how I ended up like this - first I discovered the
problem, created the fix and some elementary tests, which was added as a
Jira. Then, I expanded on the tests, and updated the patch (hence, the
-2 suffix), but this was apparently forgotten when I created the github
fork. The perils of mixing patches and github :-/ I totally agree that
we should stick to github (i.e. *one* way of doing patches)
BR
/Anders
> ResolvingGrammarGenerator doesn't implement schema resolution correctly for
> unions
> ----------------------------------------------------------------------------------
>
> Key: AVRO-2072
> URL: https://issues.apache.org/jira/browse/AVRO-2072
> Project: Avro
> Issue Type: Bug
> Reporter: Nandor Kollar
> Assignee: Nandor Kollar
> Attachments: AVRO-2072.patch
>
>
> According to
> [specification|https://avro.apache.org/docs/current/spec.html#Schema+Resolution],
> int and long is promotable to float, but when using SchemaValidator, a union
> with a single int or long branch is not readable by an union with a float
> branch.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
