[ 
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156991#comment-16156991
 ] 

Nandor Kollar commented on AVRO-2072:
-------------------------------------

Thanks [~epkanol], I uploaded AVRO-2072_2.patch with your additional test 
cases, modified the failing ones in {{TestReadingWritingDataInEvolvedSchemas}} 
which shouldn't fail after the fix in {{ResolvingGrammarGenerator}}, and 
deleted the ignored case from {{TestSchemaCompatibility}}, since we should 
support those promotions: changing the specification is not the best idea 
according to [~cutting] and [~busbey], so we should allow this promotion, thus 
this is a bug in the implementation (see discussion on Avro user's mailing 
list). Anders, could you please help with a review?

> ResolvingGrammarGenerator doesn't implement schema resolution correctly for 
> unions
> ----------------------------------------------------------------------------------
>
>                 Key: AVRO-2072
>                 URL: https://issues.apache.org/jira/browse/AVRO-2072
>             Project: Avro
>          Issue Type: Bug
>            Reporter: Nandor Kollar
>            Assignee: Nandor Kollar
>         Attachments: 0001-AVRO-1931-Additional-test-cases.patch, 
> AVRO-2072_2.patch, AVRO-2072.patch
>
>
> According to 
> [specification|https://avro.apache.org/docs/current/spec.html#Schema+Resolution],
>  int and long is promotable to float, but when using SchemaValidator, a union 
> with a single int or long branch is not readable by an union with a float 
> branch.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to