[ 
https://issues.apache.org/jira/browse/AVRO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154576#comment-16154576
 ] 

Zoltan Farkas commented on AVRO-1340:
-------------------------------------

I am not sure I like a enum defined like:

"name":"httpResponseCode",
"symbols":["UNKNOWN", "200", "404", "500", "300", "301", "302", "400"],
"symbolAliases": {"300":["301", "302"], "400": ["UNKNOWN"]}

this would imply that symbols: "300", "301", "302" are equivalent (an alias is 
just another name)... and 400 is equivalent with "UNKNOWN"... which does not 
seem right..

this would allow things like:

switch (myEnum) {
    case 300:
      dosomething
    case 301:
      dosomethingelse
}
which would be error prone..

I think the enforcing the "symbols" to be distinct (applying aliases) might 
make sense...
 

> use default to allow old readers to specify default enum value when 
> encountering new enum symbols
> -------------------------------------------------------------------------------------------------
>
>                 Key: AVRO-1340
>                 URL: https://issues.apache.org/jira/browse/AVRO-1340
>             Project: Avro
>          Issue Type: Improvement
>          Components: spec
>         Environment: N/A
>            Reporter: Jim Donofrio
>            Priority: Minor
>
> The schema resolution page says:
> > if both are enums:
> > if the writer's symbol is not present in the reader's enum, then an
> error is signalled.
> This makes it difficult to use enum's because you can never add a enum value 
> and keep old reader's compatible. Why not use the default option to refer to 
> one of enum values so that when a old reader encounters a enum ordinal it 
> does not recognize, it can default to the optional schema provided one. If 
> the old schema does not provide a default then the older reader can continue 
> to fail as it does today.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to