[
https://issues.apache.org/jira/browse/AVRO-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410214#comment-16410214
]
ASF GitHub Bot commented on AVRO-2162:
--------------------------------------
scottcarey commented on a change in pull request #303: AVRO-2162 Adds Zstandard
compression to the Avro File Format (Java)
URL: https://github.com/apache/avro/pull/303#discussion_r176557719
##########
File path: lang/java/avro/src/main/java/org/apache/avro/file/SnappyCodec.java
##########
@@ -34,50 +35,63 @@ protected Codec createInstance() {
}
}
- private SnappyCodec() {}
+ SnappyCodec() {}
@Override public String getName() { return DataFileConstants.SNAPPY_CODEC; }
@Override
public ByteBuffer compress(ByteBuffer in) throws IOException {
Review comment:
Tests were failing on only Snappy when I made some overly strict assumptions
on the returned buffer.
In the process of debugging I fixed at least one bug (not setting
ByteOrder.LITTLE_ENDIAN and letting the file format depend on the CPU of the
writer).
The code also was not properly accounting for arrayOffset in many cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add Zstandard compression to avro file format
> ---------------------------------------------
>
> Key: AVRO-2162
> URL: https://issues.apache.org/jira/browse/AVRO-2162
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Scott Carey
> Priority: Major
>
> I'd like to add Zstandard compression for Avro.
> At compression level 1 It is almost as fast as Snappy at compression, with
> compression ratios more like gzip. At higher levels of compression, it is
> more compact than gzip -9 with much lower CPU when compressing and roughly 3x
> faster decompression.
>
> Adding it to Java is fairly easy. We'll need to say something about it in
> the spec however, as an 'optinal' codec.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
