[
https://issues.apache.org/jira/browse/AVRO-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466671#comment-16466671
]
ASF GitHub Bot commented on AVRO-2079:
--------------------------------------
lukejackson commented on a change in pull request #309: AVRO-2079: Add ability
to generate Java8 native date/time classes (new)
URL: https://github.com/apache/avro/pull/309#discussion_r186588233
##########
File path:
lang/java/avro/src/main/java/org/apache/avro/data/JodaTimeConversions.java
##########
@@ -28,7 +28,7 @@
import org.joda.time.LocalDate;
import org.joda.time.LocalTime;
-public class TimeConversions {
+public class JodaTimeConversions {
Review comment:
I think it makes sense to rename this class, however in [this
comment](https://issues.apache.org/jira/browse/AVRO-2079?focusedCommentId=16402111&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16402111)
Doug Cutting states:
> The more back-compatible this is, the easier it will be to include in
releases. Currently this renames an existing class, which is not
back-compatible. As such, it thus could not be included in a minor, bugfix
release.
I assume he is referring to this class when he says this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add ability to use Java 8 date/time types instead of Joda time.
> ---------------------------------------------------------------
>
> Key: AVRO-2079
> URL: https://issues.apache.org/jira/browse/AVRO-2079
> Project: Avro
> Issue Type: Improvement
> Components: java, logical types
> Affects Versions: 1.8.2
> Reporter: Auke van Leeuwen
> Priority: Major
> Labels: patch-available
>
> Currently, for the date/time related logical types, we are generating Joda
> date/time objects. Since we've moved to Java-8 (AVRO-2043) it seems logical
> to also provide the possibility to generate {{java.time.*}} date/time objects
> instead of the Joda time variants.
> I propose to make this is a switch in {{SpecificCompiler.java}} which will
> default to Joda (I think), but can be set to generate the Java 8 versions.
> (I'm currently trying to run through the code to see if I can make it work.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
