[
https://issues.apache.org/jira/browse/AVRO-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479258#comment-16479258
]
ASF GitHub Bot commented on AVRO-2079:
--------------------------------------
nandorKollar commented on a change in pull request #309: AVRO-2079: Add ability
to generate Java8 native date/time classes (new)
URL: https://github.com/apache/avro/pull/309#discussion_r189011365
##########
File path:
lang/java/tools/src/main/java/org/apache/avro/tool/SpecificCompilerTool.java
##########
@@ -164,7 +181,7 @@ public String getShortDescription() {
System.err.println("No input files found.");
}
- return fileSet.toArray((new File[fileSet.size()]));
+ return fileSet.toArray(new File[0]);
Review comment:
Why did you change this? Since we know the size of the result array, the
original code (allocating one before toArray, and passing it) is still fine
isn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add ability to use Java 8 date/time types instead of Joda time.
> ---------------------------------------------------------------
>
> Key: AVRO-2079
> URL: https://issues.apache.org/jira/browse/AVRO-2079
> Project: Avro
> Issue Type: Improvement
> Components: java, logical types
> Affects Versions: 1.8.2
> Reporter: Auke van Leeuwen
> Priority: Major
> Labels: patch-available
>
> Currently, for the date/time related logical types, we are generating Joda
> date/time objects. Since we've moved to Java-8 (AVRO-2043) it seems logical
> to also provide the possibility to generate {{java.time.*}} date/time objects
> instead of the Joda time variants.
> I propose to make this is a switch in {{SpecificCompiler.java}} which will
> default to Joda (I think), but can be set to generate the Java 8 versions.
> (I'm currently trying to run through the code to see if I can make it work.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
