[
https://issues.apache.org/jira/browse/AVRO-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534128#comment-16534128
]
Niels Basjes commented on AVRO-2195:
------------------------------------
According to this page [https://www.apache.org/legal/resolved.html#category-a]
the BSD license is ok to include. The originating issue came to the same
conclusion: COMPRESS-423
Looking at the provided patch I noticed that the zstd-jni still needed to be
included separately in addition to the commons-compress because has explicitly
been marked as optional
[https://github.com/apache/commons-compress/blob/master/pom.xml#L87]
COMPRESS-423 does not mention why this was done.
I'm in doubt here; should we do the same or just include it as shown in the
current patch?
What I also find remarkable is that the zstd-jni is not just a dependency, it
is actually shaded into the avro jar.
I've tried the second patch but it misses the
lang/java/avro/src/main/java/org/apache/avro/file/ZstandardCodec.java
completely.
> Add Zstandard Codec
> -------------------
>
> Key: AVRO-2195
> URL: https://issues.apache.org/jira/browse/AVRO-2195
> Project: Avro
> Issue Type: New Feature
> Components: java
> Affects Versions: 1.9.0
> Reporter: Benson Qiu
> Priority: Major
> Labels: patch
> Attachments: AVRO-2195.patch, AVRO-2195.patch.v2
>
>
> Inspired by AVRO-1373. The Zstandard algorithm is available in the
> commons-library, which Avro projects already depend on.
> In a quick test that I did, Zstandard had a better compression ratio than
> deflate (compression level 9).
> [https://code.fb.com/core-data/smaller-and-faster-data-compression-with-zstandard/]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
