[ 
https://issues.apache.org/jira/browse/AVRO-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534181#comment-16534181
 ] 

Benson Qiu commented on AVRO-2195:
----------------------------------

Thanks for the comments on v2. Good to hear that the BSD license doesn't appear 
to be a blocker.
{quote}I'm in doubt here; should we do the same or just include it as shown in 
the current patch?
{quote}
I actually did not include zstd-jni in the original v1 patch. However, I had to 
include it for v2 in order to write unit tests that depend on zstd-jni.
{quote}I've tried the second patch but it misses the 
lang/java/avro/src/main/java/org/apache/avro/file/ZstandardCodec.java 
completely.
{quote}
Thanks for catching this! I will look into adding a separate unit test to 
provide test coverage for this class.

> Add Zstandard Codec
> -------------------
>
>                 Key: AVRO-2195
>                 URL: https://issues.apache.org/jira/browse/AVRO-2195
>             Project: Avro
>          Issue Type: New Feature
>          Components: java
>    Affects Versions: 1.9.0
>            Reporter: Benson Qiu
>            Priority: Major
>              Labels: patch
>         Attachments: AVRO-2195.patch, AVRO-2195.patch.v2
>
>
> Inspired by AVRO-1373. The Zstandard algorithm is available in the 
> commons-library, which Avro projects already depend on.
> In a quick test that I did, Zstandard had a better compression ratio than 
> deflate (compression level 9).
> [https://code.fb.com/core-data/smaller-and-faster-data-compression-with-zstandard/]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to