[
https://issues.apache.org/jira/browse/AVRO-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100833#comment-17100833
]
Ryan Skraba commented on AVRO-2278:
-----------------------------------
I think feature flags or system properties are a good tool! We've already got
some in place for experiments (currently set to false and hopefully will be
true in the future):
https://cwiki.apache.org/confluence/display/AVRO/Experimental+features+in+Avro
How do you think it would work here? Would we have one flag for all API
changes that we'd like to see appear in a "big bump" or one per-change?
Documented with experiments?
Since the next release is 1.10.x (pretty soon), maybe we can use this
particular clean-up as an experiment?
> GenericData.Record field getter not correct
> -------------------------------------------
>
> Key: AVRO-2278
> URL: https://issues.apache.org/jira/browse/AVRO-2278
> Project: Apache Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.8.2, 1.9.2
> Reporter: Zoltan Farkas
> Assignee: Zoltan Farkas
> Priority: Major
>
> Currently the get field implementation is not correct in GenericData.Record:
> at:
> https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/generic/GenericData.java#L209
> {code}
> @Override public Object get(String key) {
> Field field = schema.getField(key);
> if (field == null) return null;
> return values[field.pos()];
> }
> {code}
> The method returns null when a field is not present, making it impossible to
> distinguish between:
> field value = null
> and
> field does not exist.
> A more "correct" implementation would be:
> {code}
> @Override public Object get(String key) {
> Field field = schema.getField(key);
> if (field == null) {
> throw new IllegalArgumentException("Invalid field " + key);
> }
> return values[field.pos()];
> }
> {code}
> this will make the behavior consistent with put which will throw a exception
> when setting a non existent field.
> when I make this change in my fork, some bugs in unit tests showed up....
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
