[
https://issues.apache.org/jira/browse/AVRO-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113999#comment-17113999
]
Hudson commented on AVRO-2278:
------------------------------
FAILURE: Integrated in Jenkins build AvroJava #883 (See
[https://builds.apache.org/job/AvroJava/883/])
[AVRO-2278] getter semantics confusing. (#864) (github:
[https://github.com/apache/avro/commit/3a098e8be4944216f811211c9e3240fd6f67a4ae])
* (edit)
lang/java/tools/src/test/compiler/output-string/avro/examples/baseball/FieldTest.java
* (edit) lang/java/avro/src/main/java/org/apache/avro/generic/GenericRecord.java
* (edit)
lang/java/compiler/src/main/velocity/org/apache/avro/compiler/specific/templates/java/classic/record.vm
* (edit)
lang/java/tools/src/test/compiler/output-string/avro/examples/baseball/Player.java
* (edit) lang/java/tools/src/test/compiler/output/Player.java
* (edit) lang/java/avro/src/test/java/org/apache/avro/TestSchemaBuilder.java
* (edit)
lang/java/avro/src/test/java/org/apache/avro/generic/TestGenericData.java
* (edit) lang/java/avro/src/main/java/org/apache/avro/generic/GenericData.java
* (edit)
lang/java/avro/src/main/java/org/apache/avro/specific/SpecificRecordBase.java
* (edit)
lang/java/avro/src/test/java/org/apache/avro/TestReadingWritingDataInEvolvedSchemas.java
> GenericData.Record field getter not correct
> -------------------------------------------
>
> Key: AVRO-2278
> URL: https://issues.apache.org/jira/browse/AVRO-2278
> Project: Apache Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.8.2, 1.9.2
> Reporter: Zoltan Farkas
> Assignee: Zoltan Farkas
> Priority: Major
> Fix For: 1.10.0
>
>
> Currently the get field implementation is not correct in GenericData.Record:
> at:
> https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/generic/GenericData.java#L209
> {code}
> @Override public Object get(String key) {
> Field field = schema.getField(key);
> if (field == null) return null;
> return values[field.pos()];
> }
> {code}
> The method returns null when a field is not present, making it impossible to
> distinguish between:
> field value = null
> and
> field does not exist.
> A more "correct" implementation would be:
> {code}
> @Override public Object get(String key) {
> Field field = schema.getField(key);
> if (field == null) {
> throw new IllegalArgumentException("Invalid field " + key);
> }
> return values[field.pos()];
> }
> {code}
> this will make the behavior consistent with put which will throw a exception
> when setting a non existent field.
> when I make this change in my fork, some bugs in unit tests showed up....
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
