[ 
https://issues.apache.org/jira/browse/AVRO-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103167#comment-17103167
 ] 

ASF subversion and git services commented on AVRO-2745:
-------------------------------------------------------

Commit bcad995f4a70fe756decb9023575e0027c1243c0 in avro's branch 
refs/heads/master from Artur Kalimullin
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=bcad995 ]

AVRO-2745: Generate optional getters for nullables only (#817)



> Return optional through getters for nullable fields only 
> ---------------------------------------------------------
>
>                 Key: AVRO-2745
>                 URL: https://issues.apache.org/jira/browse/AVRO-2745
>             Project: Apache Avro
>          Issue Type: Improvement
>            Reporter: Artur Kalimullin
>            Priority: Minor
>
> Currently gettersReturnOptional parameter makes getters always return 
> Optional, even when the field is not nullable. I think it would be better for 
> the end user to know from the code if the field really is optional or not and 
> that's the real use case of Optional in Java.
> It can be done by either changing gettersReturnOptional behaviour or by 
> adding additional parameter that compliments the gettersReturnOptional. I 
> think the second option is better as it won't break users that are already 
> using gettersReturnOptional. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to