[ 
https://issues.apache.org/jira/browse/AVRO-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103174#comment-17103174
 ] 

Hudson commented on AVRO-2745:
------------------------------

FAILURE: Integrated in Jenkins build AvroJava #859 (See 
[https://builds.apache.org/job/AvroJava/859/])
AVRO-2745: Generate optional getters for nullables only (#817) (github: 
[https://github.com/apache/avro/commit/bcad995f4a70fe756decb9023575e0027c1243c0])
* (edit) 
lang/java/compiler/src/main/java/org/apache/avro/compiler/specific/SpecificCompiler.java
* (edit) 
lang/java/maven-plugin/src/main/java/org/apache/avro/mojo/IDLProtocolMojo.java
* (edit) 
lang/java/compiler/src/main/velocity/org/apache/avro/compiler/specific/templates/java/classic/record.vm
* (edit) 
lang/java/maven-plugin/src/main/java/org/apache/avro/mojo/ProtocolMojo.java
* (edit) 
lang/java/maven-plugin/src/main/java/org/apache/avro/mojo/SchemaMojo.java
* (edit) 
lang/java/maven-plugin/src/main/java/org/apache/avro/mojo/AbstractAvroMojo.java
* (edit) 
lang/java/compiler/src/test/java/org/apache/avro/compiler/specific/TestSpecificCompiler.java


> Return optional through getters for nullable fields only 
> ---------------------------------------------------------
>
>                 Key: AVRO-2745
>                 URL: https://issues.apache.org/jira/browse/AVRO-2745
>             Project: Apache Avro
>          Issue Type: Improvement
>            Reporter: Artur Kalimullin
>            Assignee: Artur Kalimullin
>            Priority: Minor
>             Fix For: 1.10.0
>
>
> Currently gettersReturnOptional parameter makes getters always return 
> Optional, even when the field is not nullable. I think it would be better for 
> the end user to know from the code if the field really is optional or not and 
> that's the real use case of Optional in Java.
> It can be done by either changing gettersReturnOptional behaviour or by 
> adding additional parameter that compliments the gettersReturnOptional. I 
> think the second option is better as it won't break users that are already 
> using gettersReturnOptional. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to