[
https://issues.apache.org/jira/browse/AVRO-3364?focusedWorklogId=720887&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-720887
]
ASF GitHub Bot logged work on AVRO-3364:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/22 14:10
Start Date: 04/Feb/22 14:10
Worklog Time Spent: 10m
Work Description: KyleSchoonover commented on pull request #1515:
URL: https://github.com/apache/avro/pull/1515#issuecomment-1030020381
The important part is
`public partial class GenericDatumReader<T>`
Specifically the keyword partial. There are really 2 reasons to use this.
The first is very large classes may need to be broken apart in many files for
it to be easier to maintain. The second, which is what I did was to move
complete sub classes to their own file. This actually doesn't change how the
application compiles, but more for organizational and maintenance reasons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 720887)
Time Spent: 20m (was: 10m)
> Breakout subclasses from GenericDatumReader
> -------------------------------------------
>
> Key: AVRO-3364
> URL: https://issues.apache.org/jira/browse/AVRO-3364
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.1
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Convert GenericDatumReader to a partial class. Move the subclasses to their
> own files.
> This is for 2 reason. Reduce the size of the GenericDatumReader class file,
> as well as enable easier maintenance as multiple developers work on the
> solution.
> Microsoft Reference on why to do this: [Partial Classes and Methods - C#
> Programming Guide | Microsoft
> Docs|https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/partial-classes-and-methods]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
