[
https://issues.apache.org/jira/browse/AVRO-3364?focusedWorklogId=720933&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-720933
]
ASF GitHub Bot logged work on AVRO-3364:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/22 15:25
Start Date: 04/Feb/22 15:25
Worklog Time Spent: 10m
Work Description: KyleSchoonover commented on pull request #1515:
URL: https://github.com/apache/avro/pull/1515#issuecomment-1030090020
Part of my reasoning behind this change is always code maintenance and the
ability to have multiple people working at once. I'm a bit indifferent on
whether or not we change it, but it is a habit I do. This is just going
through my first pass through of the code and getting things cleaned up a bit.
I'm ok reverting it, but will probably revisit, because I'm not 100% sure I
like the subclasses to begin with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 720933)
Time Spent: 40m (was: 0.5h)
> Breakout subclasses from GenericDatumReader
> -------------------------------------------
>
> Key: AVRO-3364
> URL: https://issues.apache.org/jira/browse/AVRO-3364
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.1
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Convert GenericDatumReader to a partial class. Move the subclasses to their
> own files.
> This is for 2 reason. Reduce the size of the GenericDatumReader class file,
> as well as enable easier maintenance as multiple developers work on the
> solution.
> Microsoft Reference on why to do this: [Partial Classes and Methods - C#
> Programming Guide | Microsoft
> Docs|https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/partial-classes-and-methods]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
