[
https://issues.apache.org/jira/browse/AVRO-3381?focusedWorklogId=724638&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-724638
]
ASF GitHub Bot logged work on AVRO-3381:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Feb/22 17:22
Start Date: 10/Feb/22 17:22
Worklog Time Spent: 10m
Work Description: KyleSchoonover commented on a change in pull request
#1530:
URL: https://github.com/apache/avro/pull/1530#discussion_r803922789
##########
File path: lang/csharp/src/apache/main/Generic/PreresolvingDatumReader.cs
##########
@@ -120,18 +123,23 @@ private ReadItem ResolveReader(Schema writerSchema,
Schema readerSchema)
{
case Schema.Type.Null:
return ReadNull;
+
case Schema.Type.Boolean:
return ReadBoolean;
+
case Schema.Type.Int:
{
switch (readerSchema.Tag)
{
case Schema.Type.Long:
- return Read(d => (long) d.ReadInt());
+ return Read(d => (long)d.ReadInt());
Review comment:
While I actually agree, it's just the pattern that is suggested that the
cast appears to be modifying the value that follows. At least with C# it may
confuse people to have a space in-between.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 724638)
Time Spent: 3h 50m (was: 3h 40m)
> Non functional changes to update styling in Avro solution
> ---------------------------------------------------------
>
> Key: AVRO-3381
> URL: https://issues.apache.org/jira/browse/AVRO-3381
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.0
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Spacing formatting fixes.
> Reference for formatting: [Code style formatting rules - .NET | Microsoft
> Docs|https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/formatting-rules]
>
> Add accessibility modifiers. Make the accessibility explicit and not implied.
> Reference: [IDE0040: Add accessibility modifiers - .NET | Microsoft
> Docs|https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0040]
>
> Remove and sort using statements: Sorting doesn't really do anything, but
> the remove part will speed up code analysis tools.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
