[
https://issues.apache.org/jira/browse/AVRO-3381?focusedWorklogId=724641&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-724641
]
ASF GitHub Bot logged work on AVRO-3381:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Feb/22 17:26
Start Date: 10/Feb/22 17:26
Worklog Time Spent: 10m
Work Description: KyleSchoonover commented on a change in pull request
#1530:
URL: https://github.com/apache/avro/pull/1530#discussion_r803926343
##########
File path: lang/csharp/src/apache/main/IO/Resolver.cs
##########
@@ -15,14 +15,14 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+
using System;
using System.Collections.Generic;
using Newtonsoft.Json.Linq;
-using Newtonsoft.Json;
namespace Avro.IO
{
- static class Resolver
+ internal static class Resolver
Review comment:
Although we may need to revisit what is publicly exposed. Things that
now have access modifiers were not accessible before since the compiler will
automatically make them internal or private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 724641)
Time Spent: 4h 20m (was: 4h 10m)
> Non functional changes to update styling in Avro solution
> ---------------------------------------------------------
>
> Key: AVRO-3381
> URL: https://issues.apache.org/jira/browse/AVRO-3381
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.0
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Spacing formatting fixes.
> Reference for formatting: [Code style formatting rules - .NET | Microsoft
> Docs|https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/formatting-rules]
>
> Add accessibility modifiers. Make the accessibility explicit and not implied.
> Reference: [IDE0040: Add accessibility modifiers - .NET | Microsoft
> Docs|https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0040]
>
> Remove and sort using statements: Sorting doesn't really do anything, but
> the remove part will speed up code analysis tools.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
