[
https://issues.apache.org/jira/browse/AVRO-3387?focusedWorklogId=724853&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-724853
]
ASF GitHub Bot logged work on AVRO-3387:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Feb/22 00:07
Start Date: 11/Feb/22 00:07
Worklog Time Spent: 10m
Work Description: KyleSchoonover opened a new pull request #1535:
URL: https://github.com/apache/avro/pull/1535
### Jira
- [ ] My PR addresses the following [Avro
Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them
in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-3387
### Tests
- [ ] My PR does not need testing for this extremely good reason: Existing
tests cover any functional changes.
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 724853)
Remaining Estimate: 0h
Time Spent: 10m
> Update BinaryDecoder to conform to C# standards
> -----------------------------------------------
>
> Key: AVRO-3387
> URL: https://issues.apache.org/jira/browse/AVRO-3387
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.0
> Reporter: Kyle Schoonover
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> # Update XML Documentation
> # Update spacing
> # remove this.
> # conform to naming
> ## ie: private readonly Stream stream
> should have the field renamed to _stream (refer to #3)
> ## don't use single letter parameters in methods
> # AvroException is a very generic exception and we should use more specific
> exceptions
> ## InvalidDataException is specific to operations on data in System.IO
> ## EndOfStreamException is specific to using System.IO.Stream
> # Delete commented code
> # Use explicit types instead of var
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
