[
https://issues.apache.org/jira/browse/AVRO-3387?focusedWorklogId=725357&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-725357
]
ASF GitHub Bot logged work on AVRO-3387:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Feb/22 18:52
Start Date: 11/Feb/22 18:52
Worklog Time Spent: 10m
Work Description: zcsizmadia commented on pull request #1535:
URL: https://github.com/apache/avro/pull/1535#issuecomment-1036516323
IMO changing the exception message is the same issue as changing the
exception type. I've seen many libraries where they rely on the actual
exception message to determine what the error was. This library pretty much has
AvroException and AvroRuntimeException, so changing the message might cause
issues as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 725357)
Time Spent: 1h 40m (was: 1.5h)
> Update BinaryDecoder to conform to C# standards
> -----------------------------------------------
>
> Key: AVRO-3387
> URL: https://issues.apache.org/jira/browse/AVRO-3387
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.0
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> # Update XML Documentation
> # Update spacing
> # remove this.
> # conform to naming
> ## ie: private readonly Stream stream
> should have the field renamed to _stream (refer to #3)
> ## don't use single letter parameters in methods
> # AvroException is a very generic exception and we should use more specific
> exceptions
> ## InvalidDataException is specific to operations on data in System.IO
> ## EndOfStreamException is specific to using System.IO.Stream
> # Delete commented code
> # Use explicit types instead of var
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
