[
https://issues.apache.org/jira/browse/AVRO-3402?focusedWorklogId=726659&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-726659
]
ASF GitHub Bot logged work on AVRO-3402:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Feb/22 22:18
Start Date: 14/Feb/22 22:18
Worklog Time Spent: 10m
Work Description: zcsizmadia commented on pull request #1549:
URL: https://github.com/apache/avro/pull/1549#issuecomment-1039628288
@KyleSchoonover @martin-g @RyanSkraba
I start to loose confidence in myself that this is the right way to handle
this. I still beleive that this effort should be grouped by warning type and
not by a massive to rework all warnings. IMO formatting warnings can be fixed
easily, however changing massive code for reworking conditions and casting
seems dangerous to me. It is hard to review so much code and the compiler
suggestion IMO cannot be trusted 100%.
Any comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 726659)
Time Spent: 2h 20m (was: 2h 10m)
> Update Avro.Main.GenericWriter to meet style guidelines
> -------------------------------------------------------
>
> Key: AVRO-3402
> URL: https://issues.apache.org/jira/browse/AVRO-3402
> Project: Apache Avro
> Issue Type: Sub-task
> Components: csharp
> Affects Versions: 1.11.0
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Update GenericWriter to meet the style guidelines outlined in editorconfig
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
