[
https://issues.apache.org/jira/browse/AVRO-3402?focusedWorklogId=726667&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-726667
]
ASF GitHub Bot logged work on AVRO-3402:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Feb/22 22:28
Start Date: 14/Feb/22 22:28
Worklog Time Spent: 10m
Work Description: zcsizmadia edited a comment on pull request #1549:
URL: https://github.com/apache/avro/pull/1549#issuecomment-1039635534
E.g. some changes like this makes me worried:
```
if (o1 is IDictionary)
vs
if (left is Array leftArray)
```
IMO that is not trivial to me if it is correct. Even if the compiler says
ok, and the unit tests pass, that is a risky change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 726667)
Time Spent: 2h 50m (was: 2h 40m)
> Update Avro.Main.GenericWriter to meet style guidelines
> -------------------------------------------------------
>
> Key: AVRO-3402
> URL: https://issues.apache.org/jira/browse/AVRO-3402
> Project: Apache Avro
> Issue Type: Sub-task
> Components: csharp
> Affects Versions: 1.11.0
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Update GenericWriter to meet the style guidelines outlined in editorconfig
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
