[ 
https://issues.apache.org/jira/browse/AVRO-3382?focusedWorklogId=727815&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-727815
 ]

ASF GitHub Bot logged work on AVRO-3382:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Feb/22 20:44
            Start Date: 15/Feb/22 20:44
    Worklog Time Spent: 10m 
      Work Description: martin-g commented on a change in pull request #1550:
URL: https://github.com/apache/avro/pull/1550#discussion_r807298566



##########
File path: lang/java/avro/src/main/java/org/apache/avro/Schema.java
##########
@@ -1585,6 +1585,13 @@ private static String validateName(String name) {
     return name;
   }
 
+  private static <T> T requireNotNull(T input, String name) {

Review comment:
       Maybe use `java.util.Objects#requireNonNull(T, java.lang.String)` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 727815)
    Time Spent: 20m  (was: 10m)

> avro allows creating Schema.FIelds with a null schema
> -----------------------------------------------------
>
>                 Key: AVRO-3382
>                 URL: https://issues.apache.org/jira/browse/AVRO-3382
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.11.0
>            Reporter: radai rosenblatt
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> either directly, or like so:
> {code:java}
> Schema badSchema = SchemaBuilder.builder("com.acme").record("BadRecord")
>   .fields().name("hasNoSchema").type((Schema) null).noDefault()
>   .endRecord(); {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to