[
https://issues.apache.org/jira/browse/AVRO-3382?focusedWorklogId=728078&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-728078
]
ASF GitHub Bot logged work on AVRO-3382:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Feb/22 07:36
Start Date: 16/Feb/22 07:36
Worklog Time Spent: 10m
Work Description: radai-rosenblatt commented on a change in pull request
#1550:
URL: https://github.com/apache/avro/pull/1550#discussion_r807625624
##########
File path: lang/java/avro/src/main/java/org/apache/avro/Schema.java
##########
@@ -1585,6 +1585,13 @@ private static String validateName(String name) {
return name;
}
+ private static <T> T requireNotNull(T input, String name) {
Review comment:
this would throw an NPE and not an IllegalArgumentException. to most
developers an NPE looks like a bug in the library rather than failed input
validation.
but ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 728078)
Time Spent: 0.5h (was: 20m)
> avro allows creating Schema.FIelds with a null schema
> -----------------------------------------------------
>
> Key: AVRO-3382
> URL: https://issues.apache.org/jira/browse/AVRO-3382
> Project: Apache Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.11.0
> Reporter: radai rosenblatt
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> either directly, or like so:
> {code:java}
> Schema badSchema = SchemaBuilder.builder("com.acme").record("BadRecord")
> .fields().name("hasNoSchema").type((Schema) null).noDefault()
> .endRecord(); {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
