[
https://issues.apache.org/jira/browse/AVRO-3441?focusedWorklogId=738682&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-738682
]
ASF GitHub Bot logged work on AVRO-3441:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Mar/22 11:23
Start Date: 09/Mar/22 11:23
Worklog Time Spent: 10m
Work Description: opwvhk commented on a change in pull request #1590:
URL: https://github.com/apache/avro/pull/1590#discussion_r822547906
##########
File path: lang/java/avro/src/test/java/org/apache/avro/TestLogicalType.java
##########
@@ -285,14 +288,20 @@ public void
testRegisterLogicalTypeWithFactoryNameNotProvided() {
IsMapContaining.hasEntry("logicalTypeName", factory));
}
+ @Test
+ public void testRegisterLogicalTypeFactoryByServiceLoader() {
+ MatcherAssert.assertThat(LogicalTypes.getCustomRegisteredTypes(),
+ IsMapContaining.hasEntry(equalTo("service-example"),
instanceOf(LogicalTypes.LogicalTypeFactory.class)));
+ }
+
public static void assertEqualsTrue(String message, Object o1, Object o2) {
- Assert.assertTrue("Should be equal (forward): " + message, o1.equals(o2));
- Assert.assertTrue("Should be equal (reverse): " + message, o2.equals(o1));
+ Assert.assertEquals("Should be equal (forward): " + message, o1, o2);
+ Assert.assertEquals("Should be equal (reverse): " + message, o2, o1);
Review comment:
Boyscout rule
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 738682)
Time Spent: 1h (was: 50m)
> Automatically register LogicalTypeFactory classes
> -------------------------------------------------
>
> Key: AVRO-3441
> URL: https://issues.apache.org/jira/browse/AVRO-3441
> Project: Apache Avro
> Issue Type: Improvement
> Components: java, logical types
> Affects Versions: 1.11.0
> Reporter: Oscar Westra van Holthe - Kind
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.11.1
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
