[ 
https://issues.apache.org/jira/browse/AVRO-3441?focusedWorklogId=738683&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-738683
 ]

ASF GitHub Bot logged work on AVRO-3441:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Mar/22 11:26
            Start Date: 09/Mar/22 11:26
    Worklog Time Spent: 10m 
      Work Description: opwvhk commented on a change in pull request #1590:
URL: https://github.com/apache/avro/pull/1590#discussion_r822547430



##########
File path: 
lang/java/avro/src/test/resources/META-INF/services/org.apache.avro.LogicalTypes$LogicalTypeFactory
##########
@@ -0,0 +1,17 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+org.apache.avro.DummyLogicalTypeFactory

Review comment:
       This is part 2 of what makes it work: a file in `META-INF/services` 
named after the _binary name_ of the interface, containing names of classes 
that implement the interface (one per line); comments and empty lines are 
ignored.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 738683)
    Time Spent: 1h 10m  (was: 1h)

> Automatically register LogicalTypeFactory classes
> -------------------------------------------------
>
>                 Key: AVRO-3441
>                 URL: https://issues.apache.org/jira/browse/AVRO-3441
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: java, logical types
>    Affects Versions: 1.11.0
>            Reporter: Oscar Westra van Holthe - Kind
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.11.1
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to