[
https://issues.apache.org/jira/browse/AVRO-3415?focusedWorklogId=739113&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-739113
]
ASF GitHub Bot logged work on AVRO-3415:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Mar/22 20:53
Start Date: 09/Mar/22 20:53
Worklog Time Spent: 10m
Work Description: zcsizmadia commented on a change in pull request #1565:
URL: https://github.com/apache/avro/pull/1565#discussion_r823079453
##########
File path: lang/csharp/src/apache/test/Avro.test.csproj
##########
@@ -32,13 +32,22 @@
</PropertyGroup>
<ItemGroup>
+ <PackageReference Include="coverlet.collector"
Version="$(CoverletCollectorVersion)">
+ <PrivateAssets>all</PrivateAssets>
+ <IncludeAssets>runtime; build; native; contentfiles; analyzers;
buildtransitive</IncludeAssets>
+ </PackageReference>
+ <PackageReference Include="coverlet.msbuild"
Version="$(CoverletMSBuildVersion)">
+ <PrivateAssets>all</PrivateAssets>
+ <IncludeAssets>runtime; build; native; contentfiles; analyzers;
buildtransitive</IncludeAssets>
+ </PackageReference>
<PackageReference Include="NUnit" Version="$(NUnitVersion)" />
<PackageReference Include="NUnit3TestAdapter"
Version="$(NUnit3TestAdapterVersion)" />
<PackageReference Include="NUnit.ConsoleRunner"
Version="$(NUnitConsoleRunnerVersion)" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk"
Version="$(MicrosoftNETTestSdkVersion)" />
+ <PackageReference Include="ReportGenerator"
Version="$(ReportGeneratorVersion)" />
Review comment:
@martin-g I let you make a call on this one. In this form I dont think
it is the best way to do it, however definetely one way to di it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 739113)
Time Spent: 6h 10m (was: 6h)
> Add C# code coverage support
> ----------------------------
>
> Key: AVRO-3415
> URL: https://issues.apache.org/jira/browse/AVRO-3415
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> This will add the following dependencies to the test project:
> coverlet.collector version 3.1.2
> coverlet.msbuild version 3.1.2
> ReportGenerator version 5.0.4
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
