[ 
https://issues.apache.org/jira/browse/AVRO-3415?focusedWorklogId=756674&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-756674
 ]

ASF GitHub Bot logged work on AVRO-3415:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Apr/22 20:26
            Start Date: 13/Apr/22 20:26
    Worklog Time Spent: 10m 
      Work Description: zcsizmadia commented on code in PR #1565:
URL: https://github.com/apache/avro/pull/1565#discussion_r849871061


##########
lang/csharp/versions.props:
##########
@@ -20,41 +20,44 @@
 -->
 

Review Comment:
   The tabulation in some places  seems to be incorrect.



##########
lang/csharp/CODECOVERAGE.md:
##########
@@ -0,0 +1,33 @@
+<!--
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+ -->
+# C# Avro Code Coverage
+
+The following instructions should be followed in order to create a code 
coverage report locally. 
+
+1. Open a command prompt
+2. Install ReportGenerator globally
+       a. Run the following command line: C:\Users\A0rk>dotnet tool install 
--global dotnet-reportgenerator-globaltool --version 5.1.4 --add-source 
https://www.nuget.org/packages/

Review Comment:
   Plz put the command between `...` and maybe remove the Windows path. This  
is cross platform command, it will work on Linux as well.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 756674)
    Time Spent: 6h 50m  (was: 6h 40m)

> Add C# code coverage support
> ----------------------------
>
>                 Key: AVRO-3415
>                 URL: https://issues.apache.org/jira/browse/AVRO-3415
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: csharp
>            Reporter: Kyle Schoonover
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 6h 50m
>  Remaining Estimate: 0h
>
> This will add the following dependencies to the test project:
> coverlet.collector version 3.1.2
> coverlet.msbuild version 3.1.2
> ReportGenerator version 5.0.4



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to