[
https://issues.apache.org/jira/browse/AVRO-3427?focusedWorklogId=739131&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-739131
]
ASF GitHub Bot logged work on AVRO-3427:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Mar/22 21:26
Start Date: 09/Mar/22 21:26
Worklog Time Spent: 10m
Work Description: KyleSchoonover commented on pull request #1594:
URL: https://github.com/apache/avro/pull/1594#issuecomment-1063387974
> Nice work. Any reason not to use a 3rd party library, eg.
https://github.com/dotnet/command-line-api (still beta, but this will be the MS
official parser in the fitire), or
https://github.com/commandlineparser/commandline? The reason I am asking is
that down the road new features need to be added. E.g. supporting multiple `-s`
and `-p` files, maybe at the same time. Custom written command line parser can
quickly become hard to maintain
I agree that using the command line parser would be a good idea assuming we
support multiple -s and -p. But this was me spending an hour doing a POC. The
only reason I didn't use a library was because it hasn't been touched for 2
years (commandlineparser). As for command-line-api, I haven't looked into it,
I personally would wait until it's out of beta. Looks like they are targeting
.NetStandard 2.0 which shouldn't cause us compatibility issues. Speaking from
experience at MS, dogfooding too early means a lot of rewrites.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 739131)
Time Spent: 8h 50m (was: 8h 40m)
> Add command line option to skip creation of directories based on namespace
> path
> -------------------------------------------------------------------------------
>
> Key: AVRO-3427
> URL: https://issues.apache.org/jira/browse/AVRO-3427
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.0
> Reporter: Paweł Kordowski
> Assignee: Paweł Kordowski
> Priority: Major
> Labels: pull-request-available
> Time Spent: 8h 50m
> Remaining Estimate: 0h
>
> In java each part of the namespace is a separate directory but that's not the
> case for C#.
> In C# you can have directory name that have many namespaces in it.
> For example:
> {noformat}
> Application.Manager.Api{noformat}
> can be a single directory name. In Java it would be 3 separate directories
> and because of that classes are generated under wrong path. it is placed in:
> {noformat}
> /Application/Manager/Api/{noformat}
> but it should be placed like here:
> {noformat}
> /Application.Manager.Api/{noformat}
> I think the best solution would be to add command line option that would skip
> creation of directories based on namespace and it would just create classes
> directly in pointed directory.
>
> Regards,
> Pawel
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
