[
https://issues.apache.org/jira/browse/AVRO-3427?focusedWorklogId=739762&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-739762
]
ASF GitHub Bot logged work on AVRO-3427:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Mar/22 22:57
Start Date: 10/Mar/22 22:57
Worklog Time Spent: 10m
Work Description: KyleSchoonover commented on pull request #1594:
URL: https://github.com/apache/avro/pull/1594#issuecomment-1064592434
@zcsizmadia
Please note, this was just a POC. Functional, yes, but more to get an idea
of how we could update it. I personally don't like all the functionality
lumped into the AvroGen.cs file.
**What is the problem we try to solve?**
I think breaking up the giant if statement logic. Hopefully making it
easier to maintain as new parameters are added.
**What are the issues and limitations with the current one?**
Testability, in regards that we can't really unit test the functionality.
Extensibility. Not necessarily us extending it, but exposing the
appropriate functionality for people to reference it and automate their
"AvroGen" process.
**What new features and bug fixes require new command line arguments or new
parsing if the current parsing is not sufficient?**
Bugs:
You can call with additional -s and -p parameters, but it is not handled if
someone tries. (generates unexpected results)
[Current bug
list](https://issues.apache.org/jira/browse/AVRO-1362?jql=project%20%3D%20AVRO%20AND%20issuetype%20%3D%20Bug%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22%2C%20Reopened%2C%20Blocked%2C%20Continued)%20AND%20component%20%3D%20csharp)
I have a feeling it's going to be additional features that are added:
ie: Display versioning, Change how the data is ouput to the directory.
Support for multiple input.
**Implement the command line parsing in-house or use a 3rd party library?**
I would say in house for now. I agree that a 3rd party library could
dramatically reduce the maintenance. But we may want this to be a follow up
story for when MS (dotnet) releases their version. Then we know it's still
being supported.
**What use cases we have with a new command line parsing? Examples what a
new avrogen could do (via scripting examples)?**
I think this is a more technical maintenance gain than a user gain. The
bigger user gain would be adding new parameters and better support for existing
parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 739762)
Time Spent: 10h 10m (was: 10h)
> Add command line option to skip creation of directories based on namespace
> path
> -------------------------------------------------------------------------------
>
> Key: AVRO-3427
> URL: https://issues.apache.org/jira/browse/AVRO-3427
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.0
> Reporter: Paweł Kordowski
> Assignee: Paweł Kordowski
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10h 10m
> Remaining Estimate: 0h
>
> In java each part of the namespace is a separate directory but that's not the
> case for C#.
> In C# you can have directory name that have many namespaces in it.
> For example:
> {noformat}
> Application.Manager.Api{noformat}
> can be a single directory name. In Java it would be 3 separate directories
> and because of that classes are generated under wrong path. it is placed in:
> {noformat}
> /Application/Manager/Api/{noformat}
> but it should be placed like here:
> {noformat}
> /Application.Manager.Api/{noformat}
> I think the best solution would be to add command line option that would skip
> creation of directories based on namespace and it would just create classes
> directly in pointed directory.
>
> Regards,
> Pawel
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
