[
https://issues.apache.org/jira/browse/AVRO-3540?focusedWorklogId=783708&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783708
]
ASF GitHub Bot logged work on AVRO-3540:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jun/22 05:58
Start Date: 22/Jun/22 05:58
Worklog Time Spent: 10m
Work Description: KalleOlaviNiemitalo commented on code in PR #1728:
URL: https://github.com/apache/avro/pull/1728#discussion_r903312028
##########
lang/csharp/src/apache/main/Reflect/DotnetProperty.cs:
##########
@@ -67,7 +67,8 @@ private bool IsPropertyCompatible(Avro.Schema.Type schemaTag)
case Avro.Schema.Type.Array:
return typeof(IEnumerable).IsAssignableFrom(propType);
case Avro.Schema.Type.Map:
- return typeof(IDictionary).IsAssignableFrom(propType);
+ var dictionaryType = typeof(IDictionary);
+ return dictionaryType.IsAssignableFrom(propType) &&
propType.GenericTypeArguments[0] == typeof(string);
Review Comment:
This reads `propType.GenericTypeArguments[0]` but shouldn't it first check
whether `propType` is a generic type at all? Or is that checked elsewhere
before this method is called?
Issue Time Tracking
-------------------
Worklog Id: (was: 783708)
Time Spent: 1h 10m (was: 1h)
> .NET/C# Allow Reflect reader/writer to support Dictionaries keyed by
> something other than string
> ------------------------------------------------------------------------------------------------
>
> Key: AVRO-3540
> URL: https://issues.apache.org/jira/browse/AVRO-3540
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Reporter: Christopher Fingar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Currently the existing reflect code does not support converting other key
> types to string.
> My change provides an opt-in functionality using the default converters.
> This allows users to keep there existing code instead of converting types to
> use string keys.
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
