[
https://issues.apache.org/jira/browse/AVRO-3540?focusedWorklogId=784053&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784053
]
ASF GitHub Bot logged work on AVRO-3540:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jun/22 06:38
Start Date: 23/Jun/22 06:38
Worklog Time Spent: 10m
Work Description: czf commented on code in PR #1728:
URL: https://github.com/apache/avro/pull/1728#discussion_r904633100
##########
lang/csharp/src/apache/main/Reflect/ClassCache.cs:
##########
@@ -252,7 +259,18 @@ public void LoadClassCache(Type objType, Schema s)
throw new AvroException($"Cant map non-generic type
{objType.Name} to map {ms.Name}");
}
- if
(!typeof(string).IsAssignableFrom(objType.GenericTypeArguments[0]))
+ var genericTypeDef = objType.GetGenericTypeDefinition();
+ if (!objType.IsInstanceOfType(typeof(IDictionary))
Review Comment:
I've reworked this a little. To be more specific on the type expectation
Issue Time Tracking
-------------------
Worklog Id: (was: 784053)
Time Spent: 2h 40m (was: 2.5h)
> .NET/C# Allow Reflect reader/writer to support Dictionaries keyed by
> something other than string
> ------------------------------------------------------------------------------------------------
>
> Key: AVRO-3540
> URL: https://issues.apache.org/jira/browse/AVRO-3540
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Reporter: Christopher Fingar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Currently the existing reflect code does not support converting other key
> types to string.
> My change provides an opt-in functionality using the default converters.
> This allows users to keep there existing code instead of converting types to
> use string keys.
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
