[
https://issues.apache.org/jira/browse/AVRO-3579?focusedWorklogId=793917&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793917
]
ASF GitHub Bot logged work on AVRO-3579:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jul/22 19:37
Start Date: 21/Jul/22 19:37
Worklog Time Spent: 10m
Work Description: timtebeek commented on PR #1769:
URL: https://github.com/apache/avro/pull/1769#issuecomment-1191861304
Are you aware of the OpenRewrite recipes to [migrate to JUnit 5 from JUnit
4](https://docs.openrewrite.org/tutorials/migrate-from-junit-4-to-junit-5)?
You can either run a command like the following in `lang/java`:
mvn org.openrewrite.maven:rewrite-maven-plugin:4.26.0:run \
-Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-testing-frameworks:1.24.0
\
-DactiveRecipes=org.openrewrite.java.testing.junit5.JUnit5BestPractices
Or run the same recipes through
https://public.moderne.io/organizations/apache/avro/master
It takes a minute or two on my machine to modify over two hundred files such
as:
modified:
android/src/test/java/org/apache/avro/util/internal/TestClassValueCache.java
modified:
avro/src/test/java/org/apache/avro/TestCircularReferences.java
modified: avro/src/test/java/org/apache/avro/TestDataFileConcat.java
...
modified:
compiler/src/test/java/org/apache/avro/compiler/idl/DocCommentHelperTest.java
modified:
compiler/src/test/java/org/apache/avro/compiler/idl/TestCycle.java
modified:
compiler/src/test/java/org/apache/avro/compiler/idl/TestIdl.java
...
modified:
grpc/src/test/java/org/apache/avro/grpc/TestAvroMarshaller.java
modified:
grpc/src/test/java/org/apache/avro/grpc/TestAvroProtocolGrpc.java
modified:
integration-test/codegen-test/src/test/java/org/apache/avro/codegentest/AbstractSpecificRecordTest.java
modified:
integration-test/codegen-test/src/test/java/org/apache/avro/codegentest/TestCustomConversion.java
modified:
integration-test/codegen-test/src/test/java/org/apache/avro/codegentest/TestLogicalTypeForStringType.java
...
modified:
ipc-jetty/src/test/java/org/apache/avro/ipc/jetty/TestBulkData.java
modified:
ipc-jetty/src/test/java/org/apache/avro/ipc/jetty/TestProtocolHttp.java
modified:
ipc-jetty/src/test/java/org/apache/avro/ipc/jetty/TestStatsPluginAndServlet.java
modified:
ipc-netty/src/test/java/org/apache/avro/ipc/netty/TestNettyServer.java
modified:
ipc-netty/src/test/java/org/apache/avro/ipc/netty/TestNettyServerConcurrentExecution.java
modified:
ipc-netty/src/test/java/org/apache/avro/ipc/netty/TestNettyServerWithCallbacks.java
...
modified: ipc/src/test/java/org/apache/avro/DataFileInteropTest.java
modified: ipc/src/test/java/org/apache/avro/RPCMetaTestPlugin.java
modified: ipc/src/test/java/org/apache/avro/TestCompare.java
...
modified:
mapred/src/test/java/org/apache/avro/hadoop/file/TestHadoopCodecFactory.java
modified:
mapred/src/test/java/org/apache/avro/hadoop/file/TestSortedKeyValueFile.java
modified:
mapred/src/test/java/org/apache/avro/hadoop/io/TestAvroDatumConverterFactory.java
...
modified: maven-plugin/pom.xml
modified:
maven-plugin/src/test/java/org/apache/avro/mojo/AbstractAvroMojoTest.java
modified:
maven-plugin/src/test/java/org/apache/avro/mojo/TestIDLProtocolMojo.java
modified:
maven-plugin/src/test/java/org/apache/avro/mojo/TestInduceMojo.java
modified:
maven-plugin/src/test/java/org/apache/avro/mojo/TestProtocolMojo.java
modified:
maven-plugin/src/test/java/org/apache/avro/mojo/TestSchemaMojo.java
modified: pom.xml
modified:
protobuf/src/test/java/org/apache/avro/protobuf/TestProtoConversions.java
modified:
protobuf/src/test/java/org/apache/avro/protobuf/TestProtobuf.java
modified: thrift/src/test/java/org/apache/avro/thrift/TestThrift.java
modified: tools/src/test/java/org/apache/avro/tool/TestCatTool.java
modified: tools/src/test/java/org/apache/avro/tool/TestConcatTool.java
modified:
tools/src/test/java/org/apache/avro/tool/TestCreateRandomFileTool.java
...
modified:
trevni/avro/src/test/java/org/apache/trevni/avro/TestCases.java
modified:
trevni/avro/src/test/java/org/apache/trevni/avro/TestEvolvedSchema.java
modified:
trevni/avro/src/test/java/org/apache/trevni/avro/TestMetadataFiltering.java
...
modified:
trevni/core/src/test/java/org/apache/trevni/TestAllCodecs.java
modified:
trevni/core/src/test/java/org/apache/trevni/TestColumnFile.java
modified:
trevni/core/src/test/java/org/apache/trevni/TestIOBuffers.java
...
One could even choose to adopt AssertJ at the same time for instance.
And if you don't want to immediately commit such a large diff, you can
choose to only commit certain modules or files separately.
Issue Time Tracking
-------------------
Worklog Id: (was: 793917)
Time Spent: 0.5h (was: 20m)
> Java Test : From Junit4 to JUnit5
> ---------------------------------
>
> Key: AVRO-3579
> URL: https://issues.apache.org/jira/browse/AVRO-3579
> Project: Apache Avro
> Issue Type: Improvement
> Reporter: Christophe Le Saec
> Assignee: Christophe Le Saec
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Progressively pass from JUnit4 to JUnit5
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
