[
https://issues.apache.org/jira/browse/AVRO-3579?focusedWorklogId=794097&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794097
]
ASF GitHub Bot logged work on AVRO-3579:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jul/22 07:41
Start Date: 22/Jul/22 07:41
Worklog Time Spent: 10m
Work Description: timtebeek commented on PR #1769:
URL: https://github.com/apache/avro/pull/1769#issuecomment-1192280820
Surprised about the specific failures you mentioned; would you mind
reporting those to
[rewrite-testing-frameworks](https://github.com/openrewrite/rewrite-testing-frameworks/issues/)?
There's already a [recipe for the parameterized tests
migration](https://github.com/openrewrite/rewrite-testing-frameworks/blob/main/src/main/java/org/openrewrite/java/testing/junit5/ParameterizedRunnerToParameterized.java#L54),
so I'm surprised it's failing.
The Arrays.equals might be inadvertently picked up as part of
[`assertTrue(a.equals(b))`
migration](https://github.com/openrewrite/rewrite-testing-frameworks/blob/main/src/main/java/org/openrewrite/java/testing/cleanup/AssertTrueEqualsToAssertEquals.java#L35).
For now it could be a good starting point indeed; I'd suggest running the
automated migration; then revert specific files with failures, and pushing the
result as a separate merge request. Any left over migrations after that can
then be tackled (and reviewed) separately. That way there's no (strong) need to
review the automated migration changes.
Issue Time Tracking
-------------------
Worklog Id: (was: 794097)
Time Spent: 50m (was: 40m)
> Java Test : From Junit4 to JUnit5
> ---------------------------------
>
> Key: AVRO-3579
> URL: https://issues.apache.org/jira/browse/AVRO-3579
> Project: Apache Avro
> Issue Type: Improvement
> Reporter: Christophe Le Saec
> Assignee: Christophe Le Saec
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Progressively pass from JUnit4 to JUnit5
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
