[
https://issues.apache.org/jira/browse/AVRO-3601?focusedWorklogId=799920&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-799920
]
ASF GitHub Bot logged work on AVRO-3601:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Aug/22 08:49
Start Date: 11/Aug/22 08:49
Worklog Time Spent: 10m
Work Description: thiru-mg commented on PR #1820:
URL: https://github.com/apache/avro/pull/1820#issuecomment-1211711217
I think moving `jsonDom.hh` to API exposes a large portion of new material
for public use. That puts a big constraint on us. Any new change to
`jsonDom.hh` needs to be backward compatible. That is the actual reason I
originally kept the entire JSON thing private. I am the author of much of the
Avro C++ work. I strongly recommend some other approach to support custom
fields. The JSON portion of the library, being private, not much thought went
into designing and implementing it. We carefully kept the JSON from the data
path, it is used only for parsing schemata and generating them. We do however
use it for generating and reading Avro data for debugging purposes.
Issue Time Tracking
-------------------
Worklog Id: (was: 799920)
Time Spent: 0.5h (was: 20m)
> C++ API header contains breaking include
> ----------------------------------------
>
> Key: AVRO-3601
> URL: https://issues.apache.org/jira/browse/AVRO-3601
> Project: Apache Avro
> Issue Type: Bug
> Reporter: Mike Ruffing
> Assignee: Martin Tzvetanov Grigorov
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Problem file/line:
> https://github.com/apache/avro/blob/master/lang/c%2B%2B/api/CustomFields.hh#L24
> Steps to reproduce:
> * Download AVRO version 1.11.1
> * Execute {{./build.sh install}} (from the {{lang/c++ directory}})
> * Navigate to the installed {{include}} directory
> * Verify this file (and path) {{"../impl/json/JsonDom.hh"}} does NOT exists
> in the installed {{include}} directory
> Relates to: https://issues.apache.org/jira/browse/AVRO-3547
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
