[
https://issues.apache.org/jira/browse/AVRO-3601?focusedWorklogId=800012&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-800012
]
ASF GitHub Bot logged work on AVRO-3601:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Aug/22 14:55
Start Date: 11/Aug/22 14:55
Worklog Time Spent: 10m
Work Description: KalleOlaviNiemitalo commented on code in PR #1821:
URL: https://github.com/apache/avro/pull/1821#discussion_r943586881
##########
lang/c++/impl/Compiler.cc:
##########
@@ -268,14 +268,14 @@ static const std::unordered_set<std::string>&
getKnownFields() {
return kKnownFields;
}
-static void getCustomAttributes(const Object& m, CustomFields
&customAttributes)
+static void getCustomAttributes(const Object& m, CustomAttributes
&customAttributes)
{
// Don't add known fields on primitive type and fixed type into custom
// fields.
const std::unordered_set<std::string>& kKnownFields = getKnownFields();
for (const auto &entry : m) {
if (kKnownFields.find(entry.first) == kKnownFields.end()) {
- customAttributes.addField(entry.first, entry.second);
+ customAttributes.addAttribute(entry.first, entry.second.stringValue());
Review Comment:
Are custom attributes required to have string values? I thought the plan was
to store a string in JSON syntax, i.e. including quotation marks if the value
is a JSON string.
Issue Time Tracking
-------------------
Worklog Id: (was: 800012)
Time Spent: 1h 50m (was: 1h 40m)
> C++ API header contains breaking include
> ----------------------------------------
>
> Key: AVRO-3601
> URL: https://issues.apache.org/jira/browse/AVRO-3601
> Project: Apache Avro
> Issue Type: Bug
> Reporter: Mike Ruffing
> Assignee: Martin Tzvetanov Grigorov
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Problem file/line:
> https://github.com/apache/avro/blob/master/lang/c%2B%2B/api/CustomFields.hh#L24
> Steps to reproduce:
> * Download AVRO version 1.11.1
> * Execute {{./build.sh install}} (from the {{lang/c++ directory}})
> * Navigate to the installed {{include}} directory
> * Verify this file (and path) {{"../impl/json/JsonDom.hh"}} does NOT exists
> in the installed {{include}} directory
> Relates to: https://issues.apache.org/jira/browse/AVRO-3547
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
