[
https://issues.apache.org/jira/browse/AVRO-3622?focusedWorklogId=805512&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-805512
]
ASF GitHub Bot logged work on AVRO-3622:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Sep/22 12:55
Start Date: 01/Sep/22 12:55
Worklog Time Spent: 10m
Work Description: RyanSkraba commented on code in PR #1843:
URL: https://github.com/apache/avro/pull/1843#discussion_r960619608
##########
lang/py/avro/test/test_schema.py:
##########
@@ -629,6 +641,10 @@ def test_invalid_name(self):
None,
None,
)
+ # A name cannot start with dot."
Review Comment:
To be very clear : `.Abc` is not currently a supported fullname. Best
practice strongly suggests that you don't use an unqualified name in a nested
named schema. Today, you're likely to run into undefined and unexpected
behaviour if you you do!
That can of worms needs to be solved but not necessarily in this PR...
Issue Time Tracking
-------------------
Worklog Id: (was: 805512)
Time Spent: 2h 50m (was: 2h 40m)
> Python compatibility check fails if record with and without namespace are
> compared
> ----------------------------------------------------------------------------------
>
> Key: AVRO-3622
> URL: https://issues.apache.org/jira/browse/AVRO-3622
> Project: Apache Avro
> Issue Type: Bug
> Components: python
> Affects Versions: 1.11.1
> Reporter: Jarkko Jaakola
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Avro spec:
> {noformat}
> To match, one of the following must hold:
> ...
> * both schemas are records with the same (unqualified) name{noformat}
> Following records are compatible. The `ReaderWriterCompatibilityChecker`
> reports name mismatch and an incompatibility. Similar test case with Java
> implementation passes.
> {code:java}
> WITHOUT_NAMESPACE_RECORD = parse(
> json.dumps(
> {
> "type": SchemaType.RECORD,
> "name": "Record1",
> "fields": [
> {
> "name": "f1",
> "type": "int",
> }
> ],
> },
> )
> )
> WITH_NAMESPACE_RECORD = parse(
> json.dumps(
> {
> "type": SchemaType.RECORD,
> "name": "ns.Record1",
> "fields": [
> {
> "name": "f1",
> "type": "int",
> }
> ],
> },
> )
> )
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
