[
https://issues.apache.org/jira/browse/AVRO-3622?focusedWorklogId=805601&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-805601
]
ASF GitHub Bot logged work on AVRO-3622:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Sep/22 17:55
Start Date: 01/Sep/22 17:55
Worklog Time Spent: 10m
Work Description: RyanSkraba commented on code in PR #1843:
URL: https://github.com/apache/avro/pull/1843#discussion_r960936350
##########
lang/py/avro/test/test_schema.py:
##########
@@ -629,6 +641,10 @@ def test_invalid_name(self):
None,
None,
)
+ # A name cannot start with dot."
+ self.assertRaises(avro.errors.InvalidName, avro.schema.Name, ".a",
None, None)
+ self.assertRaises(avro.errors.InvalidName, avro.schema.Name, "o..a",
None, None)
+ self.assertRaises(avro.errors.InvalidName, avro.schema.Name, ".a",
None, None)
Review Comment:
Repeated test? How about `"a."` for completeness!
Issue Time Tracking
-------------------
Worklog Id: (was: 805601)
Time Spent: 3h 10m (was: 3h)
> Python compatibility check fails if record with and without namespace are
> compared
> ----------------------------------------------------------------------------------
>
> Key: AVRO-3622
> URL: https://issues.apache.org/jira/browse/AVRO-3622
> Project: Apache Avro
> Issue Type: Bug
> Components: python
> Affects Versions: 1.11.1
> Reporter: Jarkko Jaakola
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Avro spec:
> {noformat}
> To match, one of the following must hold:
> ...
> * both schemas are records with the same (unqualified) name{noformat}
> Following records are compatible. The `ReaderWriterCompatibilityChecker`
> reports name mismatch and an incompatibility. Similar test case with Java
> implementation passes.
> {code:java}
> WITHOUT_NAMESPACE_RECORD = parse(
> json.dumps(
> {
> "type": SchemaType.RECORD,
> "name": "Record1",
> "fields": [
> {
> "name": "f1",
> "type": "int",
> }
> ],
> },
> )
> )
> WITH_NAMESPACE_RECORD = parse(
> json.dumps(
> {
> "type": SchemaType.RECORD,
> "name": "ns.Record1",
> "fields": [
> {
> "name": "f1",
> "type": "int",
> }
> ],
> },
> )
> )
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
