* mvn verify passes with and without network enabled
* mvn apache-ret:check passes
* mvn verify passes with -Prelease
* release signature properly signed by JB (using the KEYS file as the
keyring)
* No binary files [one false positive empty file
in ./runners/core-java/src/test/java/.placeholder we should plausibly
delete in future]
(osx: find . -type f -exec file -I '{}' \; | grep 'charset=binary')
* Module changes are as expected (microbenchmarks had a licensing issue and
was removed). Licensing for dependencies of new modules is okay (all
Apache).
new:
> apache-beam/runners/apex/pom.xml
> apache-beam/sdks/java/extensions/sorter/pom.xml
> apache-beam/sdks/java/maven-archetypes/examples-java8/pom.xml
>
apache-beam/sdks/java/maven-archetypes/examples-java8/src/main/resources/archetype-resources/pom.xml
removed:
< apache-beam/sdks/java/microbenchmarks/pom.xml
* No occurrences of the substring `incub` in the source zip.
* Ran all additional postcommits in Jenkins against the release tag, and
all passed.
So, looks good to me!
+1
Dan
On Wed, Dec 28, 2016 at 11:39 PM, Jean-Baptiste Onofré <[email protected]>
wrote:
> Minor fix & update: the source code tag is obviously v0.4.0-RC1
>
> https://git-wip-us.apache.org/repos/asf?p=beam.git;a=tag;h=r
> efs/tags/v0.4.0-RC1
>
> I launched Jenkins on the tag and it passed:
>
> https://builds.apache.org/view/Beam/job/beam_PostCommit_Java
> _MavenInstall/2245/
>
> Regards
> JB
>
>
> On 12/29/2016 08:33 AM, Jean-Baptiste Onofré wrote:
>
>> Hi everyone,
>>
>> Please review and vote on the release candidate #1 for the version
>> 0.4.0, as follows:
>>
>> [ ] +1, Approve the release
>> [ ] -1, Do not approve the release (please provide specific comments)
>>
>> The complete staging area is available for your review, which includes:
>> * JIRA release notes [1],
>> * the official Apache source release to be deployed to dist.apache.org
>> [2], which is signed with the key with fingerprint C8282E76 [3],
>> * all artifacts to be deployed to the Maven Central Repository [4],
>> * source code tag "v1.2.3-RC3" [5],
>> * website pull request listing the release and publishing the API
>> reference manual [6].
>>
>> The vote will be open for at least 72 hours. It is adopted by majority
>> approval, with at least 3 PPMC affirmative votes.
>>
>> Thanks,
>> JB
>>
>> [1]
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>> ctId=12319527&version=12338590
>>
>> [2] https://dist.apache.org/repos/dist/dev/beam/0.4.0/
>> [3] https://dist.apache.org/repos/dist/release/beam/KEYS
>> [4] https://repository.apache.org/content/repositories/orgapache
>> beam-1009/
>> [5]
>> https://git-wip-us.apache.org/repos/asf?p=beam.git;a=tag;h=a
>> b73a243ccfdae18f81435bfcf9de21c195fef4d
>>
>> [6] https://github.com/apache/beam-site/pull/117
>>
>
> --
> Jean-Baptiste Onofré
> [email protected]
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>
