@dan are you saying that mvn verify isn't doing checkstyle anymore? Some of the checkstyles are still running for a few modules. Also, the contribution docs will need to change. They say to run mvn verify before commits.
On Thu, Jan 5, 2017 at 9:25 AM Dan Halperin <dhalp...@google.com.invalid> wrote: > Several folks seem to have been confused after BEAM-246, where we moved the > "slow things" into the release profile. I've started a discussion with > https://github.com/apache/beam/pull/1740 to see if there are things we can > do to fill these gaps. > > Would love folks to chime in with opinions. > > Dan > > On Wed, Jan 4, 2017 at 1:34 PM, Jesse Anderson <je...@smokinghand.com> > wrote: > > > @Eugene, yes that failed on the checkstyle. > > > > On Wed, Jan 4, 2017 at 1:27 PM Eugene Kirpichov > > <kirpic...@google.com.invalid> wrote: > > > > > Try just -Prelease. > > > On Wed, Jan 4, 2017 at 1:21 PM Jesse Anderson <je...@smokinghand.com> > > > wrote: > > > > > > > Fails because I don't have a secret key. > > > > > > > > On Wed, Jan 4, 2017 at 1:03 PM Jean-Baptiste Onofré <j...@nanthrax.net > > > > > > wrote: > > > > > > > > > Hi Jesse, > > > > > > > > > > Could you try the same with: > > > > > > > > > > mvn verify -Prelease,apache-release > > > > > > > > > > ? > > > > > > > > > > Regards > > > > > JB > > > > > > > > > > On 01/04/2017 09:53 PM, Jesse Anderson wrote: > > > > > > For some reason, running "mvn verify" isn't running checkstyle on > > > > > > everything. I had checkstyle errors in beam-sdks-java-core that > > > weren't > > > > > > being found. > > > > > > > > > > > > I thought this was due to the extra parameters. I reran with the > > > plain > > > > > "mvn > > > > > > verify" and it still didn't find them. From the output, it > doesn't > > > look > > > > > > like they're being run at all. > > > > > > > > > > > > Thanks, > > > > > > > > > > > > Jesse > > > > > > > > > > > > > > > > -- > > > > > Jean-Baptiste Onofré > > > > > jbono...@apache.org > > > > > http://blog.nanthrax.net > > > > > Talend - http://www.talend.com > > > > > > > > > > > > > > >
