I also usually prefer "mvn verify" to to the expected thing but I see that quick iteration times are key.
As long as the pre-commit hooks still check everything I'm ok with making the default a little more lightweight. On Thu, 5 Jan 2017 at 21:49 Lukasz Cwik <[email protected]> wrote: > I was hoping that the default mvn verify would be the slow build and a > profile could be enabled that would skip checks to make things faster for > regular contributors. This way a person doesn't need to have detailed > knowledge of all our profiles and what they do (typically mvn verify) will > do the right thing most of the time. > > On Thu, Jan 5, 2017 at 9:30 AM, Dan Halperin <[email protected]> > wrote: > > > On Thu, Jan 5, 2017 at 9:28 AM, Jesse Anderson <[email protected]> > > wrote: > > > > > @dan are you saying that mvn verify isn't doing checkstyle anymore? > > > > > > `mvn verify` alone should not be running checkstyle, if modules are > > configured correctly. > > > > > > > Some of > > > the checkstyles are still running for a few modules. Also, the > > contribution > > > docs will need to change. > > > > > > Yes. The PR includes discussion of these other needed changes, > > unfortunately one PR can't change two repositories. > > > > Please continue the discussion on the PR, then I will summarize it back > > into the dev thread. > > > > Thanks, > > Dan > > > > > > > They say to run mvn verify before commits. > > > > > > On Thu, Jan 5, 2017 at 9:25 AM Dan Halperin > <[email protected] > > > > > > wrote: > > > > > > > Several folks seem to have been confused after BEAM-246, where we > moved > > > the > > > > "slow things" into the release profile. I've started a discussion > with > > > > https://github.com/apache/beam/pull/1740 to see if there are things > we > > > can > > > > do to fill these gaps. > > > > > > > > Would love folks to chime in with opinions. > > > > > > > > Dan > > > > > > > > On Wed, Jan 4, 2017 at 1:34 PM, Jesse Anderson < > [email protected]> > > > > wrote: > > > > > > > > > @Eugene, yes that failed on the checkstyle. > > > > > > > > > > On Wed, Jan 4, 2017 at 1:27 PM Eugene Kirpichov > > > > > <[email protected]> wrote: > > > > > > > > > > > Try just -Prelease. > > > > > > On Wed, Jan 4, 2017 at 1:21 PM Jesse Anderson < > > [email protected] > > > > > > > > > > wrote: > > > > > > > > > > > > > Fails because I don't have a secret key. > > > > > > > > > > > > > > On Wed, Jan 4, 2017 at 1:03 PM Jean-Baptiste Onofré < > > > [email protected] > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > Hi Jesse, > > > > > > > > > > > > > > > > Could you try the same with: > > > > > > > > > > > > > > > > mvn verify -Prelease,apache-release > > > > > > > > > > > > > > > > ? > > > > > > > > > > > > > > > > Regards > > > > > > > > JB > > > > > > > > > > > > > > > > On 01/04/2017 09:53 PM, Jesse Anderson wrote: > > > > > > > > > For some reason, running "mvn verify" isn't running > > checkstyle > > > on > > > > > > > > > everything. I had checkstyle errors in beam-sdks-java-core > > that > > > > > > weren't > > > > > > > > > being found. > > > > > > > > > > > > > > > > > > I thought this was due to the extra parameters. I reran > with > > > the > > > > > > plain > > > > > > > > "mvn > > > > > > > > > verify" and it still didn't find them. From the output, it > > > > doesn't > > > > > > look > > > > > > > > > like they're being run at all. > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > > > > > > > Jesse > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > Jean-Baptiste Onofré > > > > > > > > [email protected] > > > > > > > > http://blog.nanthrax.net > > > > > > > > Talend - http://www.talend.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
