https://github.com/apache/beam/pull/4109 is out to address both findings I reported earlier.
On Thu, Nov 9, 2017 at 8:54 AM, Etienne Chauchot <echauc...@gmail.com> wrote: > Just as a remark, I compared (on my laptop though) queries execution times > on my previous run of 2.2.0-RC3 with release 2.1.0 and I did not see any > performance regression. > > Best > > Etienne > > > Le 09/11/2017 à 03:13, Valentyn Tymofieiev a écrit : > >> I looked at Python side of Dataflow & Direct runners on Linux. There are >> two findings: >> >> 1. One of the mobile gaming examples did not pass for Dataflow runner, >> addressed in: https://github.com/apache/beam/pull/4102 >> <https://www.google.com/url?q=https%3A%2F%2Fgithub.com%2Fapa >> che%2Fbeam%2Fpull%2F4102&sa=D&sntz=1&usg=AFQjCNF3OS6Oo-MeNET >> CCmOxJj5Gm2uH6g> >> >> . >> >> 2. Python streaming did not work for Dataflow runner, one PR is out >> https://github.com/apache/beam/pull/4106, but follow up PRs may be >> required >> as we continue to investigate. If we had a PostCommit tests suite running >> against a release branch, this could have been caught earlier. Filed >> https://issues.apache.org/jira/browse/BEAM-3163. >> >> On Wed, Nov 8, 2017 at 2:39 PM, Reuven Lax <re...@google.com.invalid> >> wrote: >> >> Hi everyone, >>> >>> Please review and vote on the release candidate #3 for the version 2.2.0, >>> as follows: >>> [ ] +1, Approve the release >>> [ ] -1, Do not approve the release (please provide specific comments) >>> >>> >>> The complete staging area is available for your review, which includes: >>> * JIRA release notes [1], >>> * the official Apache source release to be deployed to >>> dist.apache.org >>> [2], >>> which is signed with the key with fingerprint B98B7708 [3], >>> * all artifacts to be deployed to the Maven Central Repository [4], >>> * source code tag "v2.2.0-RC3" [5], >>> * website pull request listing the release and publishing the API >>> reference manual [6]. >>> * Java artifacts were built with Maven 3.5.0 and OpenJDK/Oracle JDK >>> 1.8.0_144. >>> * Python artifacts are deployed along with the source release to the >>> dist.apache.org [2]. >>> >>> The vote will be open for at least 72 hours. It is adopted by majority >>> approval, with at least 3 PMC affirmative votes. >>> >>> Thanks, >>> Reuven >>> >>> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?p >>> rojectId=12319527&version=12341044 >>> [2] https://dist.apache.org/repos/dist/dev/beam/2.2.0/ >>> [3] https://dist.apache.org/repos/dist/release/beam/KEYS >>> [4] https://repository.apache.org/content/repositories/orgapache >>> beam-1023/ >>> [5] https://github.com/apache/beam/tree/v2.2.0-RC3 >>> <https://github.com/apache/beam/tree/v2.2.0-RC3> >>> [6] https://github.com/apache/beam-site/pull/337 >>> >>> >
