For the second issue, I'm just waiting for the tests to pass to merge. After that will send out a PR to cherry pick. So this should not delay the release by more than few hours. Not sure about the first issue. But given that it's a data loss I would like to get that fix in as well.
Thanks, Cham On Fri, Nov 10, 2017 at 1:18 PM Romain Manni-Bucau <rmannibu...@gmail.com> wrote: > Both issues are particular cases. Can the 2.2.0 be out and a 2.2.1 done > quickly after? Would be very appreciated to have the 2.2.0 fixes to not > depend on snapshots anymore due to some blockers found in the core of > previous releases. > > > Le 10 nov. 2017 21:23, "Chamikara Jayalath" <chamik...@google.com.invalid> > a écrit : > > > We found another issue that should probably be fixed in 2.2.0 release: > > https://issues.apache.org/jira/browse/BEAM-3172 > > > > A fix is out for review and will be merged soon. > > > > Thanks, > > Cham > > > > On Fri, Nov 10, 2017 at 10:43 AM Eugene Kirpichov > > <kirpic...@google.com.invalid> wrote: > > > > > Unfortunately I think I found a data loss bug - it was there since > 2.0.0 > > > but I think it's serious enough that delaying a fix until the next > > release > > > would be irresponsible. > > > See https://issues.apache.org/jira/browse/BEAM-3169 > > > > > > On Thu, Nov 9, 2017 at 3:57 PM Robert Bradshaw > > <rober...@google.com.invalid > > > > > > > wrote: > > > > > > > Our release notes look like nothing more than a query for the closed > > > > jira issues. Do we have a top-level summary to highlight the big > > > > ticket items in the release? And in particular somewhere to mention > > > > that this is likely the last release to support Java 7 that'll get > > > > widely read? > > > > > > > > On Thu, Nov 9, 2017 at 3:39 PM, Reuven Lax <re...@google.com.invalid > > > > > > wrote: > > > > > Thanks, > > > > > > > > > > This RC is currently failing on a number of validation steps, so we > > > need > > > > to > > > > > cut at least one more RC. Fingers crossed that it will be the last > > one. > > > > > > > > > > Reuven > > > > > > > > > > On Thu, Nov 9, 2017 at 3:36 PM, Konstantinos Katsiapis < > > > > > katsia...@google.com.invalid> wrote: > > > > > > > > > >> Just a remark: Release of Tensorflow Transform > > > > >> <https://github.com/tensorflow/transform> 0.4.0 depends on > release > > of > > > > >> Apache Beam 2.2.0 so upvoting for a release (the sooner the > better). > > > > >> > > > > >> On Thu, Nov 9, 2017 at 3:33 PM, Reuven Lax > <re...@google.com.invalid > > > > > > > >> wrote: > > > > >> > > > > >> > Are we waiting for any more validation of this candidate? If > > people > > > > are > > > > >> > still running tests I'll hold off on RC4 (to reduce the chance > of > > an > > > > >> RC5), > > > > >> > otherwise I'll cut RC4 once Valentyn's PR is merged. > > > > >> > > > > > >> > Reuven > > > > >> > > > > > >> > On Thu, Nov 9, 2017 at 2:26 PM, Valentyn Tymofieiev < > > > > >> > valen...@google.com.invalid> wrote: > > > > >> > > > > > >> > > https://github.com/apache/beam/pull/4109 is out to address > both > > > > >> > findings I > > > > >> > > reported earlier. > > > > >> > > > > > > >> > > On Thu, Nov 9, 2017 at 8:54 AM, Etienne Chauchot < > > > > echauc...@gmail.com> > > > > >> > > wrote: > > > > >> > > > > > > >> > > > Just as a remark, I compared (on my laptop though) queries > > > > execution > > > > >> > > times > > > > >> > > > on my previous run of 2.2.0-RC3 with release 2.1.0 and I did > > not > > > > see > > > > >> > any > > > > >> > > > performance regression. > > > > >> > > > > > > > >> > > > Best > > > > >> > > > > > > > >> > > > Etienne > > > > >> > > > > > > > >> > > > > > > > >> > > > Le 09/11/2017 à 03:13, Valentyn Tymofieiev a écrit : > > > > >> > > > > > > > >> > > >> I looked at Python side of Dataflow & Direct runners on > > Linux. > > > > There > > > > >> > are > > > > >> > > >> two findings: > > > > >> > > >> > > > > >> > > >> 1. One of the mobile gaming examples did not pass for > > Dataflow > > > > >> runner, > > > > >> > > >> addressed in: https://github.com/apache/beam/pull/4102 > > > > >> > > >> < > https://www.google.com/url?q=https%3A%2F%2Fgithub.com%2Fapa > > > > >> > > >> > che%2Fbeam%2Fpull%2F4102&sa=D&sntz=1&usg=AFQjCNF3OS6Oo-MeNET > > > > >> > > >> CCmOxJj5Gm2uH6g> > > > > >> > > >> > > > > >> > > >> . > > > > >> > > >> > > > > >> > > >> 2. Python streaming did not work for Dataflow runner, one > PR > > is > > > > out > > > > >> > > >> https://github.com/apache/beam/pull/4106, but follow up > PRs > > > may > > > > be > > > > >> > > >> required > > > > >> > > >> as we continue to investigate. If we had a PostCommit tests > > > suite > > > > >> > > running > > > > >> > > >> against a release branch, this could have been caught > > earlier. > > > > Filed > > > > >> > > >> https://issues.apache.org/jira/browse/BEAM-3163. > > > > >> > > >> > > > > >> > > >> On Wed, Nov 8, 2017 at 2:39 PM, Reuven Lax > > > > <re...@google.com.invalid > > > > >> > > > > > >> > > >> wrote: > > > > >> > > >> > > > > >> > > >> Hi everyone, > > > > >> > > >>> > > > > >> > > >>> Please review and vote on the release candidate #3 for the > > > > version > > > > >> > > 2.2.0, > > > > >> > > >>> as follows: > > > > >> > > >>> [ ] +1, Approve the release > > > > >> > > >>> [ ] -1, Do not approve the release (please provide > > specific > > > > >> > > comments) > > > > >> > > >>> > > > > >> > > >>> > > > > >> > > >>> The complete staging area is available for your review, > > which > > > > >> > includes: > > > > >> > > >>> * JIRA release notes [1], > > > > >> > > >>> * the official Apache source release to be deployed to > > > > >> > > >>> dist.apache.org > > > > >> > > >>> [2], > > > > >> > > >>> which is signed with the key with fingerprint B98B7708 > [3], > > > > >> > > >>> * all artifacts to be deployed to the Maven Central > > > > Repository > > > > >> > [4], > > > > >> > > >>> * source code tag "v2.2.0-RC3" [5], > > > > >> > > >>> * website pull request listing the release and > publishing > > > the > > > > >> API > > > > >> > > >>> reference manual [6]. > > > > >> > > >>> * Java artifacts were built with Maven 3.5.0 and > > > > OpenJDK/Oracle > > > > >> > JDK > > > > >> > > >>> 1.8.0_144. > > > > >> > > >>> * Python artifacts are deployed along with the source > > > > release to > > > > >> > the > > > > >> > > >>> dist.apache.org [2]. > > > > >> > > >>> > > > > >> > > >>> The vote will be open for at least 72 hours. It is adopted > > by > > > > >> > majority > > > > >> > > >>> approval, with at least 3 PMC affirmative votes. > > > > >> > > >>> > > > > >> > > >>> Thanks, > > > > >> > > >>> Reuven > > > > >> > > >>> > > > > >> > > >>> [1] https://issues.apache.org/ > > jira/secure/ReleaseNote.jspa?p > > > > >> > > >>> rojectId=12319527&version=12341044 > > > > >> > > >>> [2] https://dist.apache.org/repos/dist/dev/beam/2.2.0/ > > > > >> > > >>> [3] https://dist.apache.org/repos/dist/release/beam/KEYS > > > > >> > > >>> [4] > > > > https://repository.apache.org/content/repositories/orgapache > > > > >> > > >>> beam-1023/ > > > > >> > > >>> [5] https://github.com/apache/beam/tree/v2.2.0-RC3 > > > > >> > > >>> <https://github.com/apache/beam/tree/v2.2.0-RC3> > > > > >> > > >>> [6] https://github.com/apache/beam-site/pull/337 > > > > >> > > >>> > > > > >> > > >>> > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > > >> > > > > >> -- > > > > >> Gus Katsiapis | Software Engineer | katsia...@google.com | > > > 650-918-7487 <(650)%20918-7487> <(650)%20918-7487> > > > > <(650)%20918-7487> > > > > >> > > > > > > > > > >
