I've commented on the doc. This is a really nice analysis and I think the proposal is good for making SQL work with Beam windowing and triggering in a way that will make sense to users.
Kenn On Thu, Jan 11, 2018 at 4:05 PM, Anton Kedin <ke...@google.com> wrote: > Hi, > > Wanted to gather feedback on changes I propose to the behavior of some > aspects of windowing and triggering in Beam SQL. > > In short: > > Beam SQL currently overrides input PCollections' windowing/triggering > configuration in few cases. For example if a query has a simple GROUP BY > clause, we would apply GlobalWindows. And it's not configurable by the > user, it happens under the hood of SQL. > > Proposal is to update the Beam SQL implementation in these cases to avoid > changing the input PCollections' configuration as much as possible. > > More details here: https://docs.google.com/document/d/1RmyV9e1Qab- > axsLI1WWpw5oGAJDv0X7y9OSnPnrZWJk > > Regards, > Anton >
